Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notion of output to ModelInterface 2 #750

Merged
merged 3 commits into from Aug 20, 2019
Merged

Add notion of output to ModelInterface 2 #750

merged 3 commits into from Aug 20, 2019

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Aug 16, 2019

This implements the proposal discussed in #698 and supersedes #698.

@sdrave sdrave added pr:new-feature interfaces labels Aug 16, 2019
@sdrave sdrave added this to the 2019.2 milestone Aug 16, 2019
@sdrave sdrave requested a review from pmli Aug 16, 2019
src/pymor/models/basic.py Show resolved Hide resolved
src/pymor/models/iosys.py Outdated Show resolved Hide resolved
@renefritze
Copy link
Member

@renefritze renefritze commented Aug 19, 2019

This fails the deploy check on debian stretch. The test checks the assumption that we cannot install our wheel with the too old system python. The only way I found how to do that was to check the error message pip outputs. Which now apparently has changed twice in the last two releases. 9eaa0cc

We probably rationalize removing the stretch check now that buster is out, if nobody has a better idea.

pmli
pmli approved these changes Aug 19, 2019
@codecov
Copy link

@codecov codecov bot commented Aug 20, 2019

Codecov Report

Merging #750 into master will decrease coverage by 0.37%.
The diff coverage is 79.16%.

Impacted Files Coverage Δ
src/pymor/analyticalproblems/elliptic.py 100% <100%> (ø) ⬆️
src/pymor/discretizers/fv.py 84% <100%> (ø) ⬆️
src/pymor/reductors/basic.py 77.58% <100%> (ø) ⬆️
src/pymor/models/basic.py 82.29% <73.07%> (-3.76%) ⬇️
src/pymor/discretizers/cg.py 90.32% <77.77%> (-1.35%) ⬇️
src/pymor/models/interfaces.py 80% <83.33%> (-2.36%) ⬇️
src/pymor/vectorarrays/constructions.py 14.28% <0%> (-85.72%) ⬇️
src/pymor/vectorarrays/numpy.py 83.03% <0%> (-0.76%) ⬇️
src/pymor/algorithms/riccati.py 90.16% <0%> (-0.32%) ⬇️
src/pymor/algorithms/lrradi.py

@codecov
Copy link

@codecov codecov bot commented Aug 20, 2019

Codecov Report

Merging #750 into master will decrease coverage by 0.02%.
The diff coverage is 79.16%.

Impacted Files Coverage Δ
src/pymor/discretizers/fv.py 84% <100%> (ø) ⬆️
src/pymor/analyticalproblems/elliptic.py 100% <100%> (ø) ⬆️
src/pymor/reductors/basic.py 77.58% <100%> (ø) ⬆️
src/pymor/models/basic.py 82.29% <73.07%> (-3.76%) ⬇️
src/pymor/discretizers/cg.py 90.32% <77.77%> (-1.35%) ⬇️
src/pymor/models/interfaces.py 80% <83.33%> (-2.36%) ⬇️

sdrave and others added 3 commits Aug 20, 2019
- add output_space attribute
- add output method
- add return_output param to solve method
- change outputs dict in models.basic to output_functional
@sdrave sdrave merged commit 703ac84 into master Aug 20, 2019
7 checks passed
@sdrave sdrave deleted the model_output2 branch Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants