Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discretizers.cg] affine decomposition of robin operator and rhs functionals #760

Merged
merged 3 commits into from Sep 9, 2019

Conversation

TiKeil
Copy link
Contributor

@TiKeil TiKeil commented Sep 5, 2019

This PR addresses #727. For now the discretizer does not decompose the rhs functional F and the diffusion part of the robin boundary data although LincombFunctions might be given.

In this PR, the discretizer check for all inputs whether the input is a LincombFunction. If that's the case, the rhs functionals and robin operators in the model will also be decomposed now

@codecov
Copy link

@codecov codecov bot commented Sep 5, 2019

Codecov Report

Merging #760 into master will decrease coverage by 0.03%.
The diff coverage is 61.29%.

Impacted Files Coverage Δ
src/pymor/discretizers/cg.py 83.89% <61.29%> (-6.43%) ⬇️

1 similar comment
@codecov
Copy link

@codecov codecov bot commented Sep 5, 2019

Codecov Report

Merging #760 into master will decrease coverage by 0.03%.
The diff coverage is 61.29%.

Impacted Files Coverage Δ
src/pymor/discretizers/cg.py 83.89% <61.29%> (-6.43%) ⬇️

@sdrave sdrave changed the title [pymor/discretizers/cg] decompose robin diffusion op and rhs functionals [discretizers.cg] affine decomposition of robin operator and rhs functionals Sep 9, 2019
@sdrave sdrave added builtin-models pr:new-feature labels Sep 9, 2019
@sdrave sdrave added this to the 2019.2 milestone Sep 9, 2019
sdrave
sdrave approved these changes Sep 9, 2019
Copy link
Member

@sdrave sdrave left a comment

Thanks for your work! You should add an entry to AUTHORS.md. Maybe you could add some minimal tests for the new code, e.g. by modifying a demo script?

@TiKeil
Copy link
Contributor Author

@TiKeil TiKeil commented Sep 9, 2019

I changed AUTHORS.md.

To modify a demo script is a little bit less trivial than I thought since the elliptic.py is not parametric at all and elliptic2 has no neumann or robin conditions. Where would it fit best then?

I propose that we first merge this and discuss editing the demo later?

@sdrave sdrave merged commit 2460785 into pymor:master Sep 9, 2019
7 checks passed
@TiKeil TiKeil deleted the separate_rhs branch Sep 9, 2019
@TiKeil TiKeil restored the separate_rhs branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants