Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify implementation of project #785

merged 2 commits into from Oct 17, 2019

Simplify implementation of project #785

merged 2 commits into from Oct 17, 2019


Copy link

@sdrave sdrave commented Oct 16, 2019

By applying product to range_basis before applying ProjectRules, we don't need to pass the product everywhere.

We move the fallback case with ProjectedOperator to project()
in order to ensure that no additional basis arrays are held
in memory in case a product is specified and the RuleTable fails.
@sdrave sdrave added pr:change implementation labels Oct 16, 2019
@sdrave sdrave added this to the 2019.2 milestone Oct 16, 2019
@sdrave sdrave requested a review from pmli Oct 16, 2019
Copy link

@codecov codecov bot commented Oct 16, 2019

Codecov Report

Merging #785 into master will increase coverage by 0.03%.
The diff coverage is 86.36%.

Impacted Files Coverage Δ
src/pymor/algorithms/ 73.57% <86.36%> (+0.28%) ⬆️
src/pymor/operators/ 62.98% <0%> (+0.55%) ⬆️
src/pymor/algorithms/ 71.6% <0%> (+0.61%) ⬆️
src/pymor/core/ 84% <0%> (+8%) ⬆️

Copy link

@renefritze renefritze commented Oct 17, 2019

Seems there was a glitch in the gitlab PR bridge and its build pipeline was not created. This will probably be fixed if you push to this branch again.

pmli approved these changes Oct 17, 2019
@sdrave sdrave merged commit 4fabf45 into master Oct 17, 2019
7 checks passed
@sdrave sdrave deleted the simplify_project branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants