Simplify implementation of project #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We move the fallback case with ProjectedOperator to project() in order to ensure that no additional basis arrays are held in memory in case a product is specified and the RuleTable fails.
Codecov Report
|
|
Seems there was a glitch in the gitlab PR bridge and its build pipeline was not created. This will probably be fixed if you push to this branch again. |
pmli
reviewed
Oct 17, 2019
pmli
approved these changes
Oct 17, 2019
sdrave
force-pushed
the
simplify_project
branch
from
3adef0d
to
9251749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By applying
producttorange_basisbefore applyingProjectRules, we don't need to pass theproducteverywhere.