Skip to content

Handle projection of parametric BlockOperators#786

Merged
sdrave merged 4 commits into
masterfrom
project_blockop
Oct 17, 2019
Merged

Handle projection of parametric BlockOperators#786
sdrave merged 4 commits into
masterfrom
project_blockop

Conversation

@sdrave
Copy link
Copy Markdown
Member

@sdrave sdrave commented Oct 16, 2019

Fixes #784.

We move the fallback case with ProjectedOperator to project()
in order to ensure that no additional basis arrays are held
in memory in case a product is specified and the RuleTable fails.
@sdrave sdrave added sys-mor pr:new-feature Introduces a new feature labels Oct 16, 2019
@sdrave sdrave added this to the 2019.2 milestone Oct 16, 2019
@sdrave sdrave requested a review from pmli October 16, 2019 21:25
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 16, 2019

Codecov Report

Merging #786 into master will increase coverage by 0.06%.
The diff coverage is 90.69%.

Impacted Files Coverage Δ
src/pymor/operators/basic.py 63.04% <66.66%> (+0.61%) ⬆️
src/pymor/algorithms/projection.py 76.58% <92.5%> (+3.29%) ⬆️
src/pymor/algorithms/rules.py 71.6% <0%> (+0.61%) ⬆️
src/pymor/core/exceptions.py 84% <0%> (+8%) ⬆️

@renefritze
Copy link
Copy Markdown
Member

#785 (comment)

Comment thread src/pymor/algorithms/projection.py Outdated
Comment thread src/pymor/algorithms/projection.py
@sdrave sdrave merged commit 238b551 into master Oct 17, 2019
@sdrave sdrave deleted the project_blockop branch October 17, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:new-feature Introduces a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Projecting parametric block operators

3 participants