Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle projection of parametric BlockOperators #786

Merged
merged 4 commits into from Oct 17, 2019
Merged

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Oct 16, 2019

Fixes #784.

sdrave added 3 commits Oct 16, 2019
We move the fallback case with ProjectedOperator to project()
in order to ensure that no additional basis arrays are held
in memory in case a product is specified and the RuleTable fails.
@sdrave sdrave added sys-mor pr:new-feature labels Oct 16, 2019
@sdrave sdrave added this to the 2019.2 milestone Oct 16, 2019
@sdrave sdrave requested a review from pmli Oct 16, 2019
@codecov
Copy link

@codecov codecov bot commented Oct 16, 2019

Codecov Report

Merging #786 into master will increase coverage by 0.06%.
The diff coverage is 90.69%.

Impacted Files Coverage Δ
src/pymor/operators/basic.py 63.04% <66.66%> (+0.61%) ⬆️
src/pymor/algorithms/projection.py 76.58% <92.5%> (+3.29%) ⬆️
src/pymor/algorithms/rules.py 71.6% <0%> (+0.61%) ⬆️
src/pymor/core/exceptions.py 84% <0%> (+8%) ⬆️

@renefritze
Copy link
Member

@renefritze renefritze commented Oct 17, 2019

#785 (comment)

src/pymor/algorithms/projection.py Outdated Show resolved Hide resolved
pmli
pmli approved these changes Oct 17, 2019
@sdrave sdrave merged commit 238b551 into master Oct 17, 2019
7 checks passed
@sdrave sdrave deleted the project_blockop branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants