Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule to ProjectRules for the case that source_basis range basis are None #791

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Add rule to ProjectRules for the case that source_basis range basis are None #791

merged 2 commits into from
Oct 18, 2019

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Oct 17, 2019

No description provided.

@sdrave sdrave added sys-mor pr:change Change in existing functionality labels Oct 17, 2019
@sdrave sdrave added this to the 2019.2 milestone Oct 17, 2019
@sdrave sdrave requested a review from pmli October 17, 2019 12:33
@sdrave sdrave mentioned this pull request Oct 17, 2019
Merged
pmli
pmli approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@pmli pmli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Oct 18, 2019 •
edited
Loading

Codecov Report

Merging #791 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/pymor/algorithms/projection.py 76.87% <100%> (+0.29%) ⬆️

@sdrave sdrave merged commit b3519e6 into master Oct 18, 2019
@sdrave sdrave deleted the project_nobases branch October 18, 2019 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmli pmli pmli approved these changes

Assignees
No one assigned
Labels
pr:change Change in existing functionality
Projects
None yet
Milestone
2019.2
Development

Successfully merging this pull request may close these issues.
2 participants
@sdrave @pmli