Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use meshio for Gmsh file parsing #793

Merged
merged 5 commits into from
Oct 22, 2019
Merged

Use meshio for Gmsh file parsing #793

merged 5 commits into from
Oct 22, 2019

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Oct 18, 2019

Fixes #680.

@sdrave sdrave added pr:change Change in existing functionality implementation labels Oct 18, 2019
@sdrave sdrave added this to the 2019.2 milestone Oct 18, 2019
renefritze
renefritze approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@renefritze renefritze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes things a lot less complex 👍
Did you check which gmsh file versions meshio actually supports?

@sdrave
Copy link
Member Author

sdrave commented Oct 18, 2019

Seems like 2, 4.0 and 4.1

@codecov
Copy link

codecov bot commented Oct 18, 2019 •
edited
Loading

Codecov Report

Merging #793 into master will increase coverage by 0.62%.
The diff coverage is 80%.

Impacted Files Coverage Δ
src/pymor/domaindiscretizers/gmsh.py 75.53% <100%> (+1.06%) ⬆️
src/pymor/grids/gmsh.py 87.27% <79.31%> (+72.72%) ⬆️
src/pymor/tools/formatrepr.py 86.58% <0%> (-7.32%) ⬇️
src/pymor/discretizers/cg.py 83.89% <0%> (-1.35%) ⬇️
src/pymor/reductors/residual.py 63.63% <0%> (-1.2%) ⬇️
src/pymor/parameters/base.py 71.65% <0%> (-1.07%) ⬇️
src/pymor/algorithms/image.py 77.45% <0%> (-0.99%) ⬇️
src/pymor/algorithms/timestepping.py 77.47% <0%> (-0.91%) ⬇️
src/pymor/reductors/parabolic.py 95.12% <0%> (-0.63%) ⬇️
src/pymor/algorithms/projection.py 76.58% <0%> (-0.3%) ⬇️
... and 5 more

@renefritze
Copy link
Member

Up till now the gmsh just assumed gmsh was always installed: https://dev.azure.com/pymor/pymor/_build/results?buildId=1341

@renefritze
Copy link
Member

Or rather it xfailed when the import/gmsh call failed

@sdrave sdrave merged commit 2a384cb into master Oct 22, 2019
@sdrave sdrave deleted the meshio branch October 22, 2019 09:24
@gdmcbain gdmcbain mentioned this pull request Sep 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renefritze renefritze renefritze approved these changes

Assignees
No one assigned
Labels
pr:change Change in existing functionality
Projects
None yet
Milestone
2019.2
Development

Successfully merging this pull request may close these issues.

Replace manual gmsh file parsing
2 participants
@sdrave @renefritze