Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to newton algorithm #800

Merged
merged 2 commits into from Oct 23, 2019
Merged

Minor improvements to newton algorithm #800

merged 2 commits into from Oct 23, 2019

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Oct 22, 2019

  • add relaxation parameter
  • disable stagnation criterion by default

@sdrave sdrave added pr:new-feature pr:change labels Oct 22, 2019
@sdrave sdrave added this to the 2019.2 milestone Oct 22, 2019
@sdrave sdrave requested a review from pmli Oct 22, 2019
@sdrave
Copy link
Member Author

@sdrave sdrave commented Oct 22, 2019

BTW, none of the tags seem to fit. Maybe we should change 'linear algebra' into 'algorithms'?

@pmli
Copy link
Member

@pmli pmli commented Oct 22, 2019

Maybe we should change 'linear algebra' into 'algorithms'?

Sounds good.

pmli
pmli approved these changes Oct 22, 2019
@codecov
Copy link

@codecov codecov bot commented Oct 23, 2019

Codecov Report

Merging #800 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/pymor/algorithms/newton.py 76.92% <100%> (ø) ⬆️

@sdrave sdrave merged commit 7c68370 into master Oct 23, 2019
7 checks passed
@sdrave sdrave deleted the improve_newton branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:change pr:new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants