Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to newton algorithm #800

Merged
merged 2 commits into from
Oct 23, 2019
Merged

Minor improvements to newton algorithm #800

merged 2 commits into from
Oct 23, 2019

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Oct 22, 2019

  • add relaxation parameter
  • disable stagnation criterion by default

@sdrave sdrave added pr:new-feature Introduces a new feature pr:change Change in existing functionality labels Oct 22, 2019
@sdrave sdrave added this to the 2019.2 milestone Oct 22, 2019
@sdrave sdrave requested a review from pmli October 22, 2019 09:21
@sdrave
Copy link
Member Author

sdrave commented Oct 22, 2019

BTW, none of the tags seem to fit. Maybe we should change 'linear algebra' into 'algorithms'?

@pmli
Copy link
Member

pmli commented Oct 22, 2019

Maybe we should change 'linear algebra' into 'algorithms'?

Sounds good.

@codecov
Copy link

codecov bot commented Oct 23, 2019 •
edited
Loading

Codecov Report

Merging #800 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/pymor/algorithms/newton.py 76.92% <100%> (ø) ⬆️

@sdrave sdrave merged commit 7c68370 into master Oct 23, 2019
@sdrave sdrave deleted the improve_newton branch October 23, 2019 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmli pmli pmli approved these changes

Assignees
No one assigned
Labels
pr:change Change in existing functionality pr:new-feature Introduces a new feature
Projects
None yet
Milestone
2019.2
Development

Successfully merging this pull request may close these issues.
2 participants
@sdrave @pmli