Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make assumptions on mass Operator in InstationaryModel consistent #815

Merged
merged 3 commits into from Nov 26, 2019

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Nov 25, 2019

We allow mass to be parametric and depend on time.

Fixes #782.

@sdrave sdrave added pr:fix docs labels Nov 25, 2019
@sdrave sdrave added this to the 2019.2 milestone Nov 25, 2019
@sdrave sdrave requested a review from pmli Nov 25, 2019
src/pymor/algorithms/timestepping.py Outdated Show resolved Hide resolved
src/pymor/reductors/parabolic.py Outdated Show resolved Hide resolved
pmli
pmli approved these changes Nov 25, 2019
@codecov
Copy link

@codecov codecov bot commented Nov 26, 2019

Codecov Report

Merging #815 into master will increase coverage by 0.83%.
The diff coverage is 60%.

Impacted Files Coverage Δ
src/pymor/models/basic.py 82.29% <ø> (ø) ⬆️
src/pymor/algorithms/timestepping.py 78.18% <100%> (-0.2%) ⬇️
src/pymor/reductors/parabolic.py 92% <50%> (-3.75%) ⬇️
src/pymor/tools/vtkio.py 94.02% <0%> (-1.21%) ⬇️
src/pymor/gui/jupyter/patch.py
src/pymor/gui/jupyter/logging.py
src/pymor/gui/jupyter/__init__.py
src/pymor/gui/jupyter/threejs.py
src/pymor/gui/jupyter.py 20.12% <0%> (ø)
src/pymor/bindings/fenics.py 72.82% <0%> (+0.14%) ⬆️

@sdrave sdrave merged commit 2c280c6 into master Nov 26, 2019
8 checks passed
@sdrave sdrave deleted the fix_782 branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants