Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nonlinear Operators in FEniCS bindings #819

Merged
merged 23 commits into from Dec 12, 2019

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Dec 4, 2019

This adds FenicsOperator which can be used to wrap nonlinear UFL forms as pyMOR Operators.

Fixes #752.

@sdrave sdrave added pr:new-feature Introduces a new feature bindings labels Dec 4, 2019
@sdrave sdrave added this to the 2019.2 milestone Dec 4, 2019
@sdrave sdrave requested a review from renefritze Dec 4, 2019
@renefritze
Copy link
Member

renefritze commented Dec 5, 2019

Is this a version mismatch issue? https://zivgitlab.uni-muenster.de/pymor/pymor/-/jobs/204214
Which Fenics version did you test against, @sdrave ? Something older than 2019.1 (which should be the version in CI) maybe?

@renefritze
Copy link
Member

renefritze commented Dec 5, 2019

CI builds should be restarted once https://dev.azure.com/pymor/docker-all/_build/results?buildId=1469 has completed.

@sdrave sdrave force-pushed the fenics_nonlinear_2019_2 branch from 83d240c to 577aba6 Compare Dec 6, 2019
@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #819 into master will decrease coverage by 0.24%.
The diff coverage is 83.91%.

Impacted Files Coverage Δ
src/pymor/operators/mpi.py 18.05% <10%> (-0.47%) ⬇️
src/pymor/bindings/fenics.py 81.11% <87.83%> (+8.43%) ⬆️
src/pymor/reductors/sor_irka.py 71% <0%> (-26.37%) ⬇️
src/pymor/algorithms/lincomb.py 58.16% <0%> (-16.36%) ⬇️
src/pymor/reductors/h2.py 40.75% <0%> (-12.68%) ⬇️
src/pymor/tools/random.py 93.33% <0%> (-6.67%) ⬇️
src/pymor/discretizers/cg.py 85.23% <0%> (-4.03%) ⬇️
src/pymor/reductors/interpolation.py 79.78% <0%> (-2.24%) ⬇️
src/pymor/operators/constructions.py 85.39% <0%> (-1.05%) ⬇️
src/pymor/operators/cg.py 91.42% <0%> (-0.24%) ⬇️
... and 8 more

@sdrave sdrave force-pushed the fenics_nonlinear_2019_2 branch from 57cd08b to f67a071 Compare Dec 10, 2019
@sdrave sdrave merged commit 72fb598 into master Dec 12, 2019
@sdrave sdrave deleted the fenics_nonlinear_2019_2 branch Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:new-feature Introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge fenics_nonlinear_2019_2 branch
2 participants