Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nonlinear Operators in FEniCS bindings #819

Merged
merged 23 commits into from
Dec 12, 2019
Merged

Add support for nonlinear Operators in FEniCS bindings #819

merged 23 commits into from
Dec 12, 2019

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Dec 4, 2019

This adds FenicsOperator which can be used to wrap nonlinear UFL forms as pyMOR Operators.

Fixes #752.

@sdrave
[fenics] support subsampling in FenicsVisualizer
4063e71
@sdrave
[fenics] add FenicsOperator
e16d3d9
@sdrave
[fenics] update FenicsOperator to current pyMOR
cb9ac02 
- ensure all __init__ args are available as attributes
- account for complexifaction of FenicsVectorSpace
@sdrave
[fenics] fix typo
2a792c1
@sdrave
[tests] add FenicsOperator to operator fixtures
eee31d3
@sdrave
[fenics] fix FenicsOperator.restricted for len(dofs)==0
6803dcb
@sdrave
[fenics] remove assemble_local restriction method
6ec7677
@sdrave
[fenics] minor cleanup
b632a42
@sdrave
[fenics] support multiple DirichletBSs in FenicsOperator
100ba82
@sdrave
[fenics] add safety check in FenicsOperator.restricted
1f167ab
@sdrave
[fenics] allow restriction of DirichletBCs without user_sub_domain
ab7c636
@sdrave
[fenics] cleanup
ef69a38
@sdrave
[fenics] improve log output
1407f43
@sdrave
[fenics] fix assertion
9a340fe
@sdrave
[fenics] add comment
d39fe06
@sdrave
[fenics] add fenics_nonlinear demo
00aa05b
@sdrave sdrave added pr:new-feature Introduces a new feature bindings labels Dec 4, 2019
@sdrave sdrave added this to the 2019.2 milestone Dec 4, 2019
@renefritze
Copy link
Member

Is this a version mismatch issue? https://zivgitlab.uni-muenster.de/pymor/pymor/-/jobs/204214
Which Fenics version did you test against, @sdrave ? Something older than 2019.1 (which should be the version in CI) maybe?

@renefritze
Copy link
Member

CI builds should be restarted once https://dev.azure.com/pymor/docker-all/_build/results?buildId=1469 has completed.

@codecov
Copy link

codecov bot commented Dec 10, 2019 •
edited
Loading

Codecov Report

Merging #819 into master will decrease coverage by 0.24%.
The diff coverage is 83.91%.

Impacted Files Coverage Δ
src/pymor/operators/mpi.py 18.05% <10%> (-0.47%) ⬇️
src/pymor/bindings/fenics.py 81.11% <87.83%> (+8.43%) ⬆️
src/pymor/reductors/sor_irka.py 71% <0%> (-26.37%) ⬇️
src/pymor/algorithms/lincomb.py 58.16% <0%> (-16.36%) ⬇️
src/pymor/reductors/h2.py 40.75% <0%> (-12.68%) ⬇️
src/pymor/tools/random.py 93.33% <0%> (-6.67%) ⬇️
src/pymor/discretizers/cg.py 85.23% <0%> (-4.03%) ⬇️
src/pymor/reductors/interpolation.py 79.78% <0%> (-2.24%) ⬇️
src/pymor/operators/constructions.py 85.39% <0%> (-1.05%) ⬇️
src/pymor/operators/cg.py 91.42% <0%> (-0.24%) ⬇️
... and 8 more

@sdrave sdrave merged commit 72fb598 into master Dec 12, 2019
@sdrave sdrave deleted the fenics_nonlinear_2019_2 branch December 12, 2019 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renefritze renefritze renefritze approved these changes

Assignees
No one assigned
Labels
pr:new-feature Introduces a new feature
Projects
None yet
Milestone
2019.2
Development

Successfully merging this pull request may close these issues.

Merge fenics_nonlinear_2019_2 branch
2 participants
@sdrave @renefritze