Simplify caching and remove state ids #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdrave
added
pr:change
pmli
reviewed
Jan 8, 2020
renefritze
approved these changes
Jan 9, 2020
pmli
approved these changes
Jan 9, 2020
Can still be unreliable when using multiple processes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #838.
Note that this PR introduces an important change in the behavior of caching. When using
with_, e.g.then the
cache_regionattribute (as well as the newcache_idattribute) ofm2will be reset to the default specified in the__dict__oftype(m2). This is a consequence ofcache_regionno longer being an__init__argument. At least in the case of persistent disk caching, I think this is desirable, asm2will probably require acache_iddifferent fromm1.