Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pymor.functions to pymor.analyticalproblems.functions #858

Merged
merged 1 commit into from Jan 17, 2020

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Jan 16, 2020

This should be my last PR for cleaning up the pyMOR package. (And I think it is really helpful for new users to let them see that Functions in pyMOR are only related to defining analytical problems.)

@sdrave sdrave added pr:change builtin-models labels Jan 16, 2020
@sdrave sdrave added this to the 2020.1 milestone Jan 16, 2020
@sdrave sdrave requested review from ftalbrecht and pmli Jan 16, 2020
pmli
pmli approved these changes Jan 16, 2020
@codecov
Copy link

@codecov codecov bot commented Jan 16, 2020

Codecov Report

Merging #858 into master will decrease coverage by 0.01%.
The diff coverage is 86.11%.

Impacted Files Coverage Δ
src/pymor/analyticalproblems/text.py 97.29% <100%> (-0.08%) ⬇️
src/pymor/analyticalproblems/burgers.py 100% <100%> (ø) ⬆️
src/pymor/discretizers/builtin/fv.py 66.98% <100%> (-0.07%) ⬇️
src/pymor/discretizers/builtin/cg.py 90.98% <100%> (-0.02%) ⬇️
src/pymor/analyticalproblems/thermalblock.py 100% <100%> (ø) ⬆️
src/pymor/analyticalproblems/helmholtz.py 100% <100%> (ø) ⬆️
src/pymor/analyticalproblems/functions.py 94.92% <83.33%> (ø)

@sdrave sdrave merged commit 23389d4 into master Jan 17, 2020
7 checks passed
@sdrave sdrave deleted the move_functions branch Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants