-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename and move interface classes #859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the shortened names after reading through the changes. isinstance
checks especially feel much more natural now.
@renefritze, I have removed some old interface-related stuff in my last commit. Please take a look if you are ok with the removals. |
…nctionals.ParameterFunctional
…ons.ProjectedOperator
ed7046c
to
ca72347
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really never used the implementor reflection thingy outside of the tests? 😞
I am afraid not. |
Codecov Report
|
BasicInterface
,ImmutableInterface
,CacheableInterface
are renamed toBasicObject
,ImmutableObject
andCacheableObject
.Interface
suffix is removed from all classes.pymor.core.interfaces
is removed topymor.core.base
.pymor.*.interfaces
modules are renamed topymor.*.interface
as they all really describe only a single interface.pymor.parameters.interfaces
is split betweenpymor.parameters.spaces
andpymor.parameters.functionals
.ModelBase
andOperatorBase
are merged with the interface classes.ProjectedOperator
goes topymor.operators.constructions
.pymor.operators.basic
is renamed topymor.operators.list
.Tests still need some cleanup.