Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and move interface classes #859

Merged
merged 16 commits into from Jan 22, 2020
Merged

Rename and move interface classes #859

merged 16 commits into from Jan 22, 2020

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Jan 20, 2020

  • The base classes BasicInterface, ImmutableInterface, CacheableInterface are renamed to BasicObject, ImmutableObject and CacheableObject.
  • The Interface suffix is removed from all classes.
  • pymor.core.interfaces is removed to pymor.core.base.
  • pymor.*.interfaces modules are renamed to pymor.*.interface as they all really describe only a single interface.
  • pymor.parameters.interfaces is split between pymor.parameters.spaces and pymor.parameters.functionals.
  • ModelBase and OperatorBase are merged with the interface classes.
  • ProjectedOperator goes to pymor.operators.constructions.
  • The rest of pymor.operators.basic is renamed to pymor.operators.list.

Tests still need some cleanup.

@sdrave sdrave added pr:change Change in existing functionality interfaces labels Jan 20, 2020
@sdrave sdrave added this to the 2020.1 milestone Jan 20, 2020
@sdrave sdrave requested review from renefritze, ftalbrecht and pmli Jan 20, 2020
Copy link
Member

@renefritze renefritze left a comment

I really like the shortened names after reading through the changes. isinstance checks especially feel much more natural now.

pmli
pmli approved these changes Jan 22, 2020
@sdrave
Copy link
Member Author

@sdrave sdrave commented Jan 22, 2020

@renefritze, I have removed some old interface-related stuff in my last commit. Please take a look if you are ok with the removals.

Copy link
Member

@renefritze renefritze left a comment

We really never used the implementor reflection thingy outside of the tests? 😞

@sdrave
Copy link
Member Author

@sdrave sdrave commented Jan 22, 2020

I am afraid not.

@codecov
Copy link

@codecov codecov bot commented Jan 22, 2020

Codecov Report

Merging #859 into master will decrease coverage by 0.28%.
The diff coverage is 82.27%.

Impacted Files Coverage Δ
src/pymor/algorithms/lincomb.py 74.52% <ø> (ø) ⬆️
src/pymor/algorithms/newton.py 86.53% <ø> (ø) ⬆️
src/pymor/bindings/slycot.py 92.24% <ø> (ø) ⬆️
src/pymor/bindings/scipy.py 76.54% <ø> (ø) ⬆️
src/pymor/bindings/pymess.py 76.75% <ø> (ø) ⬆️
src/pymor/core/cache.py 85.31% <100%> (ø) ⬆️
src/pymor/discretizers/builtin/cg.py 90.98% <100%> (ø) ⬆️
.../pymor/discretizers/builtin/grids/boundaryinfos.py 96.77% <100%> (ø) ⬆️
src/pymor/operators/ei.py 66.66% <100%> (-0.27%) ⬇️
src/pymor/models/basic.py 80.51% <100%> (-1.4%) ⬇️
... and 60 more

@sdrave sdrave merged commit dcf10ce into master Jan 22, 2020
7 checks passed
@sdrave sdrave deleted the rename_interfaces branch Jan 22, 2020
@pmli pmli mentioned this pull request Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:change Change in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants