Implement VectorArrayOperator.apply_inverse #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@renefritze, seems like a (new?) CI issue ... |
Member
You need to rebase on master |
sdrave
force-pushed
the
vectorarrayoperator_apply_inverse
branch
from
32fa583 to
dd27957
Compare
pmli
reviewed
Feb 28, 2020
Member
pmli
left a comment
pmli
left a comment
There was a problem hiding this comment.
Looks good to me. Are there tests for least-squares solvers?
Member
Author
|
@pmli, good point. I thought we had a test, but it is only for |
Member
|
Maybe just a couple of small, well-conditioned, randomly generated examples, one overdetermined and one underdetermined? Just to see that it works when it should. |
pmli
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
VectorArrayOperator.apply_inversevia a QR decomposition of the correspondingVectorArray(usinggram_schmidt).In particular this is relevant for nonlinear least-squares ROMs without hyperreduction, in which case the projected Jacobians are
VectorArrayOperatorsandapply_inverseis called withleast_squares=True.