Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement VectorArray.__deepcopy__ via VectorArray.copy(deep=True) #895

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Implement VectorArray.__deepcopy__ via VectorArray.copy(deep=True) #895

merged 1 commit into from
Mar 10, 2020

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Mar 10, 2020

This is primarily needed for DummyPool which will fail to push unpicklable VectorArrays.

Fixes #893.

@sdrave sdrave added this to the 2020.1 milestone Mar 10, 2020
@sdrave sdrave mentioned this pull request Mar 10, 2020
Closed
@codecov
Copy link

codecov bot commented Mar 10, 2020 •
edited
Loading

Codecov Report

Merging #895 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
src/pymor/vectorarrays/interface.py 79.71% <100.00%> (+0.19%) ⬆️

@sdrave sdrave merged commit 1e5eaf7 into master Mar 10, 2020
@sdrave sdrave deleted the fix_893 branch March 10, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:fix Fixes a bug
Projects
None yet
Milestone
2020.1
Development

Successfully merging this pull request may close these issues.

Thermalblock demo fails with parameters FEnics + without estimator
1 participant
@sdrave