Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add from_files method to SecondOrderModel #905

Merged
merged 1 commit into from Apr 14, 2020
Merged

Add from_files method to SecondOrderModel #905

merged 1 commit into from Apr 14, 2020

Conversation

pmli
Copy link
Member

@pmli pmli commented Apr 6, 2020

This basically copies from_files method from LTIModel to SecondOrderModel.

I'm hesitant about adding from_mat_file (SLICOT benchmarks that use .mat files only use the first-order form) or something like from_mekbcd_files (in Oberwolfach benchmarks there is usually one C matrix which conflicts with our Cp and Cv notation).

@pmli pmli added pr:new-feature generic-objects labels Apr 6, 2020
@pmli pmli added this to the 2020.1 milestone Apr 6, 2020
@pmli pmli self-assigned this Apr 6, 2020
@pmli
Copy link
Member Author

@pmli pmli commented Apr 7, 2020

@renefritze Any idea what's wrong with the CI?

@renefritze
Copy link
Member

@renefritze renefritze commented Apr 7, 2020

Our openstack infrastructure has been in maintenance since monday morning. I'll restart failed jobs once I the WWU IT has fixed everything's they've broken.

@renefritze
Copy link
Member

@renefritze renefritze commented Apr 8, 2020

I just learned it could be days until our IT brings our CI runner back up.
I have a potential stop-gap measure for this in 63eee51
This ofc slow down the pipelines since I cannot run many builds in parallel. If
https://zivgitlab.uni-muenster.de/pymor/pymor/pipelines/57610 goes green you can cherry-pick that commit if you want to go ahead with this PR, @pmli

@codecov
Copy link

@codecov codecov bot commented Apr 8, 2020

Codecov Report

Merging #905 into master will decrease coverage by 0.04%.
The diff coverage is 18.18%.

Impacted Files Coverage Δ
src/pymor/models/iosys.py 46.56% <18.18%> (-0.45%) ⬇️

@renefritze
Copy link
Member

@renefritze renefritze commented Apr 9, 2020

Maybe hold off on getting the workaround, @pmli, there's hope for today after all.

@pmli
Copy link
Member Author

@pmli pmli commented Apr 9, 2020

Ok, I'm actually not in a hurry to merge this.

@renefritze
Copy link
Member

@renefritze renefritze commented Apr 14, 2020

Usual CI is back up, I've restarted a bunch of old builds. No need for the workaround at this time.

@pmli
Copy link
Member Author

@pmli pmli commented Apr 14, 2020

Great, thanks.

@pmli pmli merged commit 3fb8b30 into master Apr 14, 2020
7 checks passed
@pmli pmli deleted the so-from-files branch Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants