Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[newton] fixed bugs with residual being exactly 0 #932

Merged
merged 3 commits into from Jun 2, 2020

Conversation

HenKlei
Copy link
Member

@HenKlei HenKlei commented May 28, 2020

Addresses #927.

This merge request fixes a bug that occurred when the residual in the Newton algorithm becomes exactly 0.

@codecov
Copy link

@codecov codecov bot commented May 28, 2020

Codecov Report

Merging #932 into master will not change coverage.
The diff coverage is n/a.

Impacted Files Coverage Δ
src/pymor/algorithms/newton.py 86.53% <ø> (ø)

Copy link
Member

@sdrave sdrave left a comment

Thanks for the fix, @HenKlei. Maybe it would be more elegant to require atol/rtol to be >= 0 and to let both default to 0? What do you think?

@HenKlei
Copy link
Member Author

@HenKlei HenKlei commented May 29, 2020

Yes, I think that's better. That was also my first idea. Then we can remove the first if-condition, I think. As far as I can see, the second one is required nevertheless.

@sdrave
Copy link
Member

@sdrave sdrave commented May 29, 2020

As far as I can see, the second one is required nevertheless.

Don't think so. If error_squence[-1] is not the current but the last error. And if it was zero, then we would have aborted the loop?!

@HenKlei
Copy link
Member Author

@HenKlei HenKlei commented May 29, 2020

Don't think so. If error_squence[-1] is not the current but the last error. And if it was zero, then we would have aborted the loop?!

Yeah, you're absolutely right. Having 0 as default value for atol and rtol, that should work.

@HenKlei
Copy link
Member Author

@HenKlei HenKlei commented May 29, 2020

I think this is the simplest solution now. The test is also working as expected. Thus, merging is fine with me.
@sdrave Do you have any objections or further comments?

@sdrave
Copy link
Member

@sdrave sdrave commented Jun 2, 2020

Looks good to me! I will merge as is.

@sdrave sdrave merged commit 7deb4a0 into pymor:master Jun 2, 2020
8 checks passed
@sdrave sdrave added this to the 2020.1 milestone Jun 2, 2020
@sdrave sdrave added algorithms pr:fix labels Jun 2, 2020
@HenKlei HenKlei deleted the fix-newton branch Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants