-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[parameters/functionals] Add derivative of products #934
[parameters/functionals] Add derivative of products #934
Conversation
Codecov Report
|
@TiKeil, is there a reason for not just implementing the product rule and checking the individual summands for being zero? |
You are right, this would probably be the most rigorous way of implementing it. The reason why I did not do it was that for my applications I only needed this very simple special case. |
da79228
to
d19857c
Compare
@sdrave , I think I have implemented what you suggested in d19857c. This code still only works if there is only one factor which has a non vanishing derivative. I think we can not support derivatives of products with more than one summand in the product rule unless we implement the '+' operator for |
Yes, I think we should add a Would you like to see this PR in the next release or is it ok to wait after 2020.1? |
I can add it. In a separate PR I guess?
I think after adding |
Great! Yes.
Fine, I added it to the milestone. |
…eneral product rule
d19857c
to
42ef5fc
Compare
I used #950 to finish the product rule and added a more advanced test for it |
Co-authored-by: Stephan Rave <stephanrave@uni-muenster.de>
Co-authored-by: Stephan Rave <stephanrave@uni-muenster.de>
c31998e
to
42d693b
Compare
This seems to be done |
If the
ProductParameterFunctional
is simply a number times aParameterFunctional
, we can easily compute thed_mu
for this. However, it is required to automatically detect this case. So, we first count the actual number ofParameterFunctional
s in the product and compute the derivative in case, there is only oneParameterFunctional
.With this code, one can then go ahead and implement product rules and generalizations for more parameters, if needed.