Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NumpyListVectorArrayMatrixOperator out of the playground #937

Merged
merged 7 commits into from Jun 4, 2020

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Jun 3, 2020

When the thermalblock demo is called with --list-vector-array all NumpyMatrixOperators are replaced by a ListVectorArray-based analogon. The code existed in pyMOR for quite a while and was in a broken state. As I find the code quite useful for unit and performance testing of ListVectorArray I decided to move it out of the playground instead of deleting it.

In the process, I also modernized the code, using RuleTables and ListVectorArrayOperatorBase.

This is also a first step to close #890.

@sdrave sdrave added pr:change pr:fix builtin-models labels Jun 3, 2020
@sdrave sdrave added this to the 2020.1 milestone Jun 3, 2020
@sdrave sdrave requested review from renefritze and pmli Jun 3, 2020
@codecov
Copy link

@codecov codecov bot commented Jun 3, 2020

Codecov Report

Merging #937 into master will increase coverage by 0.13%.
The diff coverage is 86.88%.

Impacted Files Coverage Δ
src/pymor/operators/numpy.py 78.50% <66.66%> (ø)
src/pymor/discretizers/builtin/list.py 84.84% <84.84%> (ø)
src/pymor/operators/list.py 64.00% <95.45%> (+10.15%) ⬆️

pmli
pmli approved these changes Jun 3, 2020
@sdrave sdrave merged commit 276ca52 into master Jun 4, 2020
13 checks passed
@sdrave sdrave deleted the move_numpylistop_out_of_playground branch Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:change pr:fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants