Move NumpyListVectorArrayMatrixOperator out of the playground #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to allow reuse in NumpyListVectorArrayMatrixOperator. Also, fail if matrix is sparse.
…etizers.builtin.list
Codecov Report
|
renefritze
approved these changes
Jun 3, 2020
pmli
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When the thermalblock demo is called with
--list-vector-arrayallNumpyMatrixOperatorsare replaced by aListVectorArray-based analogon. The code existed in pyMOR for quite a while and was in a broken state. As I find the code quite useful for unit and performance testing ofListVectorArrayI decided to move it out of the playground instead of deleting it.In the process, I also modernized the code, using
RuleTablesandListVectorArrayOperatorBase.This is also a first step to close #890.