Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verbose name for d_mu functionals #959

Merged
merged 3 commits into from Jun 19, 2020

Conversation

TiKeil
Copy link
Contributor

@TiKeil TiKeil commented Jun 18, 2020

As proposed in #950, we can use a better name for derivatives of ParameterFunctionals.

@TiKeil TiKeil force-pushed the add_a_proper_name_to_d_mu branch from 165e0f6 to 97142bf Compare Jun 18, 2020
@codecov
Copy link

@codecov codecov bot commented Jun 18, 2020

Codecov Report

Merging #959 into master will not change coverage.
The diff coverage is 90.00%.

Impacted Files Coverage Δ
src/pymor/parameters/functionals.py 93.68% <90.00%> (ø)

Copy link
Member

@sdrave sdrave left a comment

You missed `ProductParameterFunctional. Apart from that, LGTM.

@TiKeil
Copy link
Contributor Author

@TiKeil TiKeil commented Jun 19, 2020

You missed `ProductParameterFunctional. Apart from that, LGTM.

Thanks, I forgot about #950 .

sdrave
sdrave approved these changes Jun 19, 2020
@TiKeil
Copy link
Contributor Author

@TiKeil TiKeil commented Jun 19, 2020

This is maybe something that an 'intermediate' developer should have:

The rights to restart randomly failing tests.

@renefritze
Copy link
Member

@renefritze renefritze commented Jun 19, 2020

This is maybe something that an 'intermediate' developer should have:

The rights to restart randomly failing tests.

Please notify me when something like this happens so I can try to find the underlying cause.

@pmli
Copy link
Member

@pmli pmli commented Jun 19, 2020

There seems to be a real error:

>           return LincombParameterFunctional(summands, [1] * len(summands), name=f'{self.name}_d_{parameter}_{index}')
E           NameError: name 'parameter' is not defined
src/pymor/parameters/functionals.py:302: NameError

@TiKeil
Copy link
Contributor Author

@TiKeil TiKeil commented Jun 19, 2020

There seems to be a real error:

>           return LincombParameterFunctional(summands, [1] * len(summands), name=f'{self.name}_d_{parameter}_{index}')
E           NameError: name 'parameter' is not defined
src/pymor/parameters/functionals.py:302: NameError

Wow this is true... Where did you see this? I did not find something like this in the ci output ...

@renefritze
Copy link
Member

@renefritze renefritze commented Jun 19, 2020

@TiKeil
Copy link
Contributor Author

@TiKeil TiKeil commented Jun 19, 2020

https://zivgitlab.uni-muenster.de/pymor/pymor/-/jobs/344319#L1025 for example

Thanks, I should learn to find this better. It feels like I always only find half the reasons why the test fail

@renefritze
Copy link
Member

@renefritze renefritze commented Jun 19, 2020

Does the log scroll down to bottom for you when you view build step's log in gitlab?

Towards the bottom there's always a section "short test summary info" where all failed tests are listed. With that info you should always find the corresponding back traces further up in the log.

@pmli
Copy link
Member

@pmli pmli commented Jun 19, 2020

I usually just do Ctrl+F error...

@TiKeil
Copy link
Contributor Author

@TiKeil TiKeil commented Jun 19, 2020

I know how to deal with the log but this time I actually could not find the log. Thank you both

@sdrave sdrave merged commit f51fe45 into pymor:master Jun 19, 2020
8 checks passed
@sdrave sdrave added this to the 2020.1 milestone Jun 19, 2020
@sdrave sdrave added implementation pr:change labels Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants