Ensure that Parameters and Mu instances are always ordered alphabetically #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TiKeil, please take a look .. |
|
Looks good. Thanks |
Codecov Report
|
renefritze
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, there have been several issues with parameters not being ordered, e.g. #977. With this PR all
ParametersandMuinstances will always be ordered alphabetically.The implementation relies on Python >= 3.7 and CPython >= 3.6 dicts being insertion ordered.
Obviously this may have some impact on performance. (Creating a
Frozendict(b=3, a=2)takes 1.5 microseconds on my machine whereas creating aSortedFrozenDict(b=3, a=2)takes 2.5 microseconds.) But I would assume that this is negligible in most cases, and avoiding subtle bugs due to invalid implicit assumptions seems more important.