Raise exception if as_dict=True and column(s) have no names #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative solution to the issue in #157, suggested by @rsyring.
@rsyring proposed that we modify pymssql to raise an exception when the user uses
as_dict=True
and then does a query which returns output columns that are not named; the current behavior of omitting those columns is very confusing -- e.g.:Note that we don't provide a name for the
MAX(x)
column above.Currently, we don't add the column to the result row if it has no name. This confuses people. See this mailing list thread for an example.
I have a more detailed example at: https://gist.github.com/msabramo/8319097
So the new behavior with this change is:
and it works nicely even when there are multiple columns without names: