Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _mssql.pyx to resolve #576 #591

Closed
wants to merge 1 commit into from

Conversation

@tonyravioli
Copy link

commented Aug 30, 2018

Needs to be tested, but potentially resolves #576.

@tonyravioli

This comment has been minimized.

Copy link
Author

commented Aug 30, 2018

I'm the opposite of experienced with doing pull requests, but I think I did everything right. Not sure about why these tests are failing, as it doesn't look like it's related to the one line I changed. Also not sure how to have anyone look at this besides pinging @AlexHagerman even though I'd rather let him hang out with his new baby :(

@AlexHagerman

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2018

She sleeps sometimes :) I don't mind reviewing PRs right now. And opening PRs is how everybody learns, so don't worry about that. Unfortunately our repo is in a non standard state right now where active development is happening on stable-2.1.x instead of master. Issue #569 will correct that, but I need to understand some details of 2.2.x vs 2.1.x first.

Anyways what that means is after you fork and clone the repo you will need to do a fetch so you have all branches available. Some helpful docs are here:

https://help.github.com/articles/fetching-a-remote/
https://help.github.com/articles/syncing-a-fork/
https://stackoverflow.com/questions/9537392/git-fetch-remote-branch

So what this will roughly look like is

Github fork the repo
git clone the repo
(you've done these steps)
git fetch origin
git checkout stable-2.1.x
make your changes
git add <filename>
git commit -m "<description>" git push`

Then in GitHub open a PR (you've done this I know), but when you do switch the branch of pymssql:master to pymssql:stable-2.1.x so that you're pushing against the branch with active development.

That branch also has the .circleci config that should make Circle build against our workflow versus the default.

Hope that helps, any questions please feel free to ask.

@tonyravioli

This comment has been minimized.

Copy link
Author

commented Aug 30, 2018

I appreciate you pointing me in the right direction with those links and the steps - people like you make getting involved in the open source community seem less scary to people like me. Thanks for the friendly help. I'll close this PR and try to use that information to commit to stable-2.1.x from my fork's stable-2.1.x branch, after making the changes in that branch of my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.