Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update _mssql.pyx to resolve #576 #591
I'm the opposite of experienced with doing pull requests, but I think I did everything right. Not sure about why these tests are failing, as it doesn't look like it's related to the one line I changed. Also not sure how to have anyone look at this besides pinging @AlexHagerman even though I'd rather let him hang out with his new baby :(
She sleeps sometimes :) I don't mind reviewing PRs right now. And opening PRs is how everybody learns, so don't worry about that. Unfortunately our repo is in a non standard state right now where active development is happening on
Anyways what that means is after you fork and clone the repo you will need to do a fetch so you have all branches available. Some helpful docs are here:
So what this will roughly look like is
Github fork the repo
Then in GitHub open a PR (you've done this I know), but when you do switch the branch of
That branch also has the
Hope that helps, any questions please feel free to ask.
I appreciate you pointing me in the right direction with those links and the steps - people like you make getting involved in the open source community seem less scary to people like me. Thanks for the friendly help. I'll close this PR and try to use that information to commit to stable-2.1.x from my fork's stable-2.1.x branch, after making the changes in that branch of my fork.