Removed numpy deprecation warnings #362

Open
scopatz opened this Issue Mar 8, 2014 · 8 comments

Comments

Projects
None yet
2 participants

@scopatz scopatz added build labels Mar 8, 2014

Contributor

crbates commented Mar 9, 2014

I seem to remember spending about an hour trying to get this to work for the cython files when working on #221/#222 without any success. I think this has to be done upstream in cython, but I could be wrong.

Owner

scopatz commented Mar 9, 2014

I seem to recall that as well. I'll look into it.

Owner

scopatz commented Mar 9, 2014

So I can turn off the old API with adding the following in CMakeLists:

add_definitions(-DNPY_NO_DEPRECATED_API=NPY_1_7_API_VERSION)

but then the build fails because Cython is using the old API!

@scopatz scopatz added this to the v0.5 milestone Mar 27, 2014

Owner

scopatz commented Nov 16, 2014

This can be done by removing the string from the cxx files that are generated by cython.

Contributor

crbates commented Feb 11, 2015

@scopatz do we want to add a sed command to do this in the build?

Owner

scopatz commented Feb 11, 2015

I think so. It would be nice. It might be tricky though, because we'd have to copy some of the cython files over locally.

Owner

scopatz commented Feb 11, 2015

I'd be fine with moving this to v0.6, too.

@crbates crbates modified the milestones: v0.6, v0.5 Feb 11, 2015

Contributor

crbates commented Feb 11, 2015

yuck, 0.6 it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment