-
-
Notifications
You must be signed in to change notification settings - Fork 921
Docs update #767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs update #767
Conversation
That looks like a nice improvement to the documentation! |
Thanks @karray and @stefnotch ! Aside for the external example link (that it would indeed be better not include) LGTM. |
Thanks for your feedback. I removed the external link and added a couple of new examples. |
Why do we need // set the pyodide files URL (packages.json, pyodide.asm.data etc)
window.languagePluginUrl = 'https://pyodide-cdn2.iodide.io/v0.15.0/full/'; Everything seems to work without this line of code since the var languagePluginLoader = new Promise((resolve, reject) => {
// ...
var baseURL = self.languagePluginUrl || 'https://pyodide-cdn2.iodide.io/v0.15.0/full/';
// ... |
Yes, it will work with the default URL but it will fail when using a locally deployed pyodide server. It's better to include it explicitly so users don't run into hard to debug errors with local deployments. |
Thanks @karray ! |
I've added one more example to "Using Pyodide from Javascript".
As this is my first experience contributing open source projects, I would like to ask is it allowed to include an external link to a live demo into the docs?