Rewrite script to use vendor packages if possible #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Danny's 2 for 2! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started by quoting variables, fixing the misplaced quote in the awk command, and simplifying the script --but then things got a little out of hand as I really wanted to use my vendor's python packages where possible instead of installing with pip. :D
So, there's support for OpenSUSE, SLE, and Ubuntu packages in there now. It'll still fall back to
pipfor any deps which aren't able to be installed withzypper/apt(and for systems which aren't SUSE or Ubuntu).