Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop python 3.6 for cibuildwheel driver #1175

Merged
merged 3 commits into from
Jul 29, 2022
Merged

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Jul 14, 2022

This drops python 3.6 for cibuildwheel.
Building python 3.6 packages is still supported.

closes #508

@mayeut mayeut force-pushed the python-3.7 branch 2 times, most recently from 5654a1b to 47e7aef Compare July 14, 2022 12:02
unit_test/conftest.py Outdated Show resolved Hide resolved
@mayeut mayeut marked this pull request as ready for review July 14, 2022 13:29
@@ -37,6 +32,8 @@ repos:
rev: 5.10.1
hooks:
- id: isort
args: ["-a", "from __future__ import annotations"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added this before I could suggest it. :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooo 👀

Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎 LGTM once the tests are green!

@joerick
Copy link
Contributor

joerick commented Jul 15, 2022

Let's hold this until after the next patch release (2.8.1)

This drops python 3.6 for cibuildwheel.
Building python 3.6 packages is still supported.
test_build_default_launches was using cibuildwheel setup.cfg which led to the test failing once python 3.6 was dropped.
Use an empty package, provided by fake_package_dir, to run the test.
@joerick joerick merged commit 4db339c into pypa:main Jul 29, 2022
@mayeut mayeut deleted the python-3.7 branch July 30, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] Raise minimum required Python to 3.7
3 participants