/ cibuildwheel Public
fix: not skipping the tests stops the copy (Windows ARM) #1377
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
If you don't skip the tests, the final copy of the wheels is skipped after printing the warning message when cross-compiling for Win ARM!
IMO, these should be refactored to one function per action (prepare, build, repair, test, finalize, something like that) instead of massive, all-in-one function that's hard to track; it would make bugs like this harder to make. Blocks should not be more than a few lines.