Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not skipping the tests stops the copy (Windows ARM) #1377

merged 1 commit into from Dec 22, 2022


Copy link

@henryiii henryiii commented Dec 15, 2022

If you don't skip the tests, the final copy of the wheels is skipped after printing the warning message when cross-compiling for Win ARM!

IMO, these should be refactored to one function per action (prepare, build, repair, test, finalize, something like that) instead of massive, all-in-one function that's hard to track; it would make bugs like this harder to make. Blocks should not be more than a few lines.

Signed-off-by: Henry Schreiner <>
@henryiii henryiii changed the title fix: not skipping the tests stops the copy fix: not skipping the tests stops the copy (Windows ARM) Dec 15, 2022
Copy link

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes! Yes that's a dodgy copy/paste indeed.

On the refactor note, hard to say without seeing it, but you might be right. Consistency across the three platforms (e.g. function names) would also be nice.

@henryiii henryiii merged commit 3dcc2ff into pypa:main Dec 22, 2022
23 checks passed
@henryiii henryiii deleted the henryiii/fix/winnoskip branch December 22, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants