Repository navigation
Fix quoting of test-requires and audit-requires options for PEP 508 specifiers - #2913
Merged
agriyakhetarpal merged 5 commits intoJun 13, 2026
Merged
Conversation
agriyakhetarpal
added a commit
to agriyakhetarpal/numcodecs
that referenced
this pull request
Jun 12, 2026
agriyakhetarpal
added a commit
to agriyakhetarpal/numcodecs
that referenced
this pull request
Jun 12, 2026
This reverts commit 97e9153.
agriyakhetarpal
changed the title
test-requires option for PEP 508 specifierstest-requires and audit-requires options for PEP 508 specifiers
agriyakhetarpal
marked this pull request as ready for review
June 12, 2026 21:27
henryiii
approved these changes
Jun 12, 2026
Contributor
|
good catch, thanks |
justinjoy
added a commit
to semantic-reasoning/PyreWire
that referenced
this pull request
Aug 7, 2026
Bumps pypa/cibuildwheel from v4.1.0 to v4.1.1 in the release and wheels workflows. test_wheel_workflows_use_cibuildwheel_v4_1_0 pins the exact cibuildwheel version both wheel-building workflows must use, so the bump has to update that guard in lockstep. Bumping the workflows alone fails CI, which is why the Dependabot-only diff could not go green. The guard is renamed to match the version it now asserts, and v4.1.0 joins the list of superseded versions the workflows must not fall back to. v4.1.1 is a patch release: no breaking changes, and its test-requires quoting fix (pypa/cibuildwheel#2913) applies to the pytest/pytest-cov test-requires this project already configures.
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-requiresandaudit-requireswere formatted with a space-joinedListFormat(sep=" ")without any quoting and then split with.split(), and that breaks any requirement containing a space, such as a dependency specifier of the form"pyzstd; python_version >= '3.14'"test-sourcescorrectly usesListFormat(sep=" ", quote=shlex.quote)andshlex.split(), so this is a trivial fix where the same pattern should be applied for both places.Closes #2912