Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force bytecode directories and files always to exclude #581

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Force bytecode directories and files always to exclude #581

merged 1 commit into from
Oct 20, 2022

Conversation

nanonyme
Copy link
Contributor

@nanonyme nanonyme force-pushed the nanonyme/bytecode branch 4 times, most recently from ca66dee to a8e0ecc Compare August 20, 2022 11:38
@nanonyme
Copy link
Contributor Author

@takluyver is this what you suggested?

@nanonyme nanonyme marked this pull request as ready for review August 24, 2022 18:42
@nanonyme
Copy link
Contributor Author

I tried using this by byte-compiling flit_core, then creating sdist of flit_core. There were no pyc files inside said package.

@takluyver
Copy link
Member

Thanks, that is what I was suggesting. Can we add a note in the docs about the sdist section that these files are always excluded?

@nanonyme
Copy link
Contributor Author

Sure, I will apply requested changes later today.

@takluyver takluyver added this to the 3.8 milestone Oct 20, 2022
@takluyver takluyver merged commit 7b13fb2 into pypa:main Oct 20, 2022
@takluyver
Copy link
Member

Thanks!

@nanonyme nanonyme deleted the nanonyme/bytecode branch October 20, 2022 16:34
@nanonyme
Copy link
Contributor Author

Is there any plan when next release will happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takluyver takluyver takluyver left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.
2 participants
@nanonyme @takluyver