New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for manylinux2010 rollout #179

Open
ncoghlan opened this Issue Apr 14, 2018 · 12 comments

Comments

Projects
None yet
10 participants
@ncoghlan
Member

ncoghlan commented Apr 14, 2018

I've accepted the manylinux2010 PEP, so that's now an active interoperability standard: https://www.python.org/dev/peps/pep-0571/

However, there are a number of further steps needed before folks can actually make use of that new baseline, and the order of operations matters (since building manylinux2010 wheels isn't very useful if installers won't install them):

Essential client support:

  • Update pip 10.x to install manylinux2010 wheels (PR: pypa/pip#5410)
  • Update pip 9.x to install manylinux2010 wheels (needed to avoid the manylinux2010 rollout being delayed by the Python API break between pip 9.x and pip 10.x) (@ncoghlan: skip for now, wait and see if we get complaints about needing this)
  • Update pipenv to install manylinux2010 wheels (needed due to pipenv being impacted by the pip 9->10 API break, and hence currently vendoring its own copy of pip 9.x) (@ncoghlan: skip this, since the pip 10 compatible pipenv isn't too far away: #179 (comment))

Enable publication of manylinux2010 wheel archives:

  • Update auditwheel to emit manylinux2010 wheel archives (PR: pypa/auditwheel#92)
  • Provide a manylinux2010 build environment here (see #152 for initial PR)
  • Confirm that twine will upload manylinux2010 wheel archives
  • Update warehouse to accept manylinux2010 wheel uploads (pypa/warehouse#3951)

Management of transition from manylinux1:

  • Update https://packaging.python.org/specifications/platform-compatibility-tags/ to cover manylinux2010, with the caveat that it doesn't actually have broad tooling support yet
  • Nominate a timeline and/or "percentage of PyPI downloads by manylinux2010 compatible installers" for switching the default build environment and auditwheel output to manylinux2010
  • Nominate criteria for rewording and eventually removing the "not yet widely supported" caveat from the platform compatibility tagging page (likely related to completion of other tasks noted above)

Additional projects to consider once core capability support has rolled out:

Tagging @takluyver @markrwilliams as the PEP 571 authors, and @di and @brainwane from the PyPI/PSF side of things.

@ncoghlan ncoghlan referenced this issue Apr 14, 2018

Open

Manylinux2 #152

@markrwilliams

This comment has been minimized.

Show comment
Hide comment

markrwilliams commented Apr 14, 2018

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Apr 15, 2018

Member

Updating the spec page on PyPUG:

pypa/python-packaging-user-guide#470

Member

takluyver commented Apr 15, 2018

Updating the spec page on PyPUG:

pypa/python-packaging-user-guide#470

mayeut added a commit to mayeut/warehouse that referenced this issue May 12, 2018

Allow manylinux2010 wheel upload
manylinux2010 platform tag is official per PEP571

see also pypa/manylinux#179
@mayeut

This comment has been minimized.

Show comment
Hide comment
@mayeut

mayeut May 12, 2018

Contributor

Confirm that twine will upload manylinux2010 wheel archives

Confirmed

Update warehouse to accept manylinux2010 wheel uploads

PR: pypa/warehouse#3951

Contributor

mayeut commented May 12, 2018

Confirm that twine will upload manylinux2010 wheel archives

Confirmed

Update warehouse to accept manylinux2010 wheel uploads

PR: pypa/warehouse#3951

di added a commit to pypa/warehouse that referenced this issue May 14, 2018

Allow manylinux2010 wheel upload (#3951)
manylinux2010 platform tag is official per PEP571

see also pypa/manylinux#179
@di

This comment has been minimized.

Show comment
Hide comment
@di

di May 14, 2018

Member

pypa/warehouse#3951 has been merged.

Member

di commented May 14, 2018

pypa/warehouse#3951 has been merged.

@wtolson

This comment has been minimized.

Show comment
Hide comment
@wtolson

wtolson May 15, 2018

pip merge request has been updated here: pypa/pip#5410

wtolson commented May 15, 2018

pip merge request has been updated here: pypa/pip#5410

@wtolson

This comment has been minimized.

Show comment
Hide comment
@wtolson

wtolson May 15, 2018

auditwheel merge request has been updated here: pypa/auditwheel#92

wtolson commented May 15, 2018

auditwheel merge request has been updated here: pypa/auditwheel#92

@armudgal

This comment has been minimized.

Show comment
Hide comment
@armudgal

armudgal May 17, 2018

Hi,
First of all great job with this, I just wanted to know is there an estimate when the manylinux2010 will roll-out. Thanks :)

armudgal commented May 17, 2018

Hi,
First of all great job with this, I just wanted to know is there an estimate when the manylinux2010 will roll-out. Thanks :)

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver May 17, 2018

Member

There's no one roll-out date, because support needs to be added to various different tools in the ecosystem (see the list at the top of the issue). I imagine that it's probably a matter of a few weeks to a few months before you can use it and expect it to work.

Member

takluyver commented May 17, 2018

There's no one roll-out date, because support needs to be added to various different tools in the ecosystem (see the list at the top of the issue). I imagine that it's probably a matter of a few weeks to a few months before you can use it and expect it to work.

@armudgal

This comment has been minimized.

Show comment
Hide comment
@armudgal

armudgal May 20, 2018

Oh, thanks for the information

armudgal commented May 20, 2018

Oh, thanks for the information

@techalchemy

This comment has been minimized.

Show comment
Hide comment
@techalchemy

techalchemy May 23, 2018

Member

@ncoghlan Pipenv will have pip 10 support after we merge pypa/pipenv#2255 which un-vendors pip9 completely, and bundles a patched version of pip10 which can be re-vendored and patched when updates land (this was possible because pip-tools accepted my PR which makes them pip10 compatible as well)

so whenever the pr lands in pip we can make the call about whether to actually go ahead and pull that into our patched version before it's released (technically we could do this now, even) and we will be set

Member

techalchemy commented May 23, 2018

@ncoghlan Pipenv will have pip 10 support after we merge pypa/pipenv#2255 which un-vendors pip9 completely, and bundles a patched version of pip10 which can be re-vendored and patched when updates land (this was possible because pip-tools accepted my PR which makes them pip10 compatible as well)

so whenever the pr lands in pip we can make the call about whether to actually go ahead and pull that into our patched version before it's released (technically we could do this now, even) and we will be set

@westurner

This comment has been minimized.

Show comment
Hide comment
@westurner

westurner Sep 17, 2018

"SEC: Spectre variant 2: GCC: -mindirect-branch=thunk -mindirect-branch-register"
https://mail.python.org/mm3/archives/list/distutils-sig@python.org/thread/4BGE226DB5EWIAT5VCJ75QD5ASOVJZCM/

westurner commented Sep 17, 2018

"SEC: Spectre variant 2: GCC: -mindirect-branch=thunk -mindirect-branch-register"
https://mail.python.org/mm3/archives/list/distutils-sig@python.org/thread/4BGE226DB5EWIAT5VCJ75QD5ASOVJZCM/

@safijari

This comment has been minimized.

Show comment
Hide comment
@safijari

safijari Oct 13, 2018

Other than the open pull requests needing to get merged, is there any more left to do for this effort? How can I help?

safijari commented Oct 13, 2018

Other than the open pull requests needing to get merged, is there any more left to do for this effort? How can I help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment