Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a license section to the distributing guide #331

Merged
merged 2 commits into from
Jun 23, 2017
Merged

Add a license section to the distributing guide #331

merged 2 commits into from
Jun 23, 2017

Conversation

theacodes
Copy link
Member

Resolves #275

@theacodes theacodes requested review from ddbeck and ncoghlan June 23, 2017 16:25
ddbeck
ddbeck approved these changes Jun 23, 2017
View reviewed changes
Copy link
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding this, Jon.

source/tutorials/distributing-packages.rst
If you're unsure which license to choose, you can use resources such as
`GitHub's Choose a License <https://choosealicense.com/>`_ or consult a lawyer.

For an example, see the `LICENSE.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less a change suggestion and more of an observation: I would write "see file_name from…" or "see the file_name file from…" This is a personal preference I had no idea I even had until this moment, so thank you for this learning experience. 😆

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to be consistent here. We'll eventually replace this whole page with new tutorials, so I'm just trying to get a band-aid in place for the time being. :)

@theacodes theacodes merged commit c49bd8e into pypa:master Jun 23, 2017
@theacodes theacodes deleted the add-license-to-guide branch June 23, 2017 16:47
ncoghlan pushed a commit to ncoghlan/packaging.python.org that referenced this pull request Jun 24, 2017
@ncoghlan
Add a license section to the distributing guide (pypa#331)
615d463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theacodes @ddbeck