Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a license section to the distributing guide #331

Merged
merged 2 commits into from Jun 23, 2017

Conversation

@theacodes
Copy link
Member

commented Jun 23, 2017

Resolves #275

@theacodes theacodes requested review from ddbeck and ncoghlan Jun 23, 2017

@ddbeck

ddbeck approved these changes Jun 23, 2017

Copy link
Contributor

left a comment

Looks great! Thanks for adding this, Jon.

If you're unsure which license to choose, you can use resources such as
`GitHub's Choose a License <https://choosealicense.com/>`_ or consult a lawyer.

For an example, see the `LICENSE.txt

This comment has been minimized.

Copy link
@ddbeck

ddbeck Jun 23, 2017

Contributor

Less a change suggestion and more of an observation: I would write "see file_name from…" or "see the file_name file from…" This is a personal preference I had no idea I even had until this moment, so thank you for this learning experience. 😆

This comment has been minimized.

Copy link
@theacodes

theacodes Jun 23, 2017

Author Member

I'm trying to be consistent here. We'll eventually replace this whole page with new tutorials, so I'm just trying to get a band-aid in place for the time being. :)

@theacodes theacodes merged commit c49bd8e into pypa:master Jun 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@theacodes theacodes deleted the theacodes:add-license-to-guide branch Jun 23, 2017

ncoghlan added a commit to ncoghlan/python-packaging-user-guide that referenced this pull request Jun 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.