-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated content on 'installing scientific packages' page #455
Conversation
@jonparrott Can you please review this? Thanks |
packages, it is not limited to just Python packages. It has full support for | ||
native virtual environments. Conda makes environments first-class citizens, | ||
making it easy to create independent environments even for C libraries. It is | ||
written in Python, but is Python-agnostic. Conda manages python itself as a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question, why did you lower-case "python" here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed it. Will Capitalize it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed
929d9a6
to
5642436
Compare
@brainwane I missed changing |
I'm thinking those "Last Reviewed" and "Page Status" markers may have served their purpose now, and we'd be best off dropping them entirely. IIRC, we added them back around 2014 when our tooling recommendations were sometimes changing from month to month as we discovered new problems with the various available options, and the PyPUG wasn't well enough known yet for corrections to be sent in as PRs. |
Thanks for the response @ncoghlan . So shall I go ahead and remove |
@waseem18 Aye, go ahead. |
5642436
to
b8cdae2
Compare
@waseem18 ready to be re-reviewed? |
Yes @brainwane - I've removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny punctuation suggestion.
common denominator" and publishing that as a wheel file on PyPI. | ||
Starting with version 1.10.4 of NumPy and version 1.0.0 of SciPy, pre-built | ||
32-bit and 64-bit binaries in the ``wheel`` format are available for all major | ||
operating systems (Windows, macOS, and Linux) on PyPI. Note however that on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be:
Note, however, that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed.
Capitalized 'Python' Remove page status and last reviewed markers Resolved code review
b8cdae2
to
084524d
Compare
Fixes #383