Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated content on 'installing scientific packages' page #455

Merged
merged 1 commit into from Mar 20, 2018

Conversation

waseem18
Copy link
Contributor

@waseem18 waseem18 commented Mar 11, 2018

Fixes #383

@waseem18
Copy link
Contributor Author

waseem18 commented Mar 11, 2018

@jonparrott Can you please review this?

Thanks

packages, it is not limited to just Python packages. It has full support for
native virtual environments. Conda makes environments first-class citizens,
making it easy to create independent environments even for C libraries. It is
written in Python, but is Python-agnostic. Conda manages python itself as a
Copy link
Member

@brainwane brainwane Mar 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question, why did you lower-case "python" here?

Copy link
Contributor Author

@waseem18 waseem18 Mar 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed it. Will Capitalize it

Copy link
Contributor Author

@waseem18 waseem18 Mar 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

@waseem18
Copy link
Contributor Author

waseem18 commented Mar 11, 2018

@brainwane I missed changing Last Reviewed - changing it to today's date. What about Page Status? Currently it says Incomplete.

@ncoghlan
Copy link
Member

ncoghlan commented Mar 12, 2018

I'm thinking those "Last Reviewed" and "Page Status" markers may have served their purpose now, and we'd be best off dropping them entirely.

IIRC, we added them back around 2014 when our tooling recommendations were sometimes changing from month to month as we discovered new problems with the various available options, and the PyPUG wasn't well enough known yet for corrections to be sent in as PRs.

@waseem18
Copy link
Contributor Author

waseem18 commented Mar 12, 2018

Thanks for the response @ncoghlan . So shall I go ahead and remove Last Reviewed and Page Status ?

@ncoghlan
Copy link
Member

ncoghlan commented Mar 12, 2018

@waseem18 Aye, go ahead.

@brainwane
Copy link
Member

brainwane commented Mar 14, 2018

@waseem18 ready to be re-reviewed?

@waseem18
Copy link
Contributor Author

waseem18 commented Mar 14, 2018

Yes @brainwane - I've removed the Last Reviewed and Page Status as per @ncoghlan 's review.

Copy link
Member

@brainwane brainwane left a comment

Tiny punctuation suggestion.

common denominator" and publishing that as a wheel file on PyPI.
Starting with version 1.10.4 of NumPy and version 1.0.0 of SciPy, pre-built
32-bit and 64-bit binaries in the ``wheel`` format are available for all major
operating systems (Windows, macOS, and Linux) on PyPI. Note however that on
Copy link
Member

@brainwane brainwane Mar 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be:

Note, however, that

Copy link
Contributor Author

@waseem18 waseem18 Mar 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

Capitalized 'Python'

Remove page status and last reviewed markers

Resolved code review
@theacodes theacodes merged commit f1268b9 into pypa:master Mar 20, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants