Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve binary extension docs #531

Merged
merged 3 commits into from Jul 3, 2018

Conversation

@thewtex
Copy link
Contributor

commented Jul 3, 2018

No description provided.

@theacodes theacodes merged commit 5439033 into pypa:master Jul 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@theacodes

This comment has been minimized.

Copy link
Member

commented Jul 3, 2018

Thanks, @thewtex!

@thewtex thewtex deleted the thewtex:improve-binary-extension-docs branch Jul 3, 2018

@thewtex

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2018

Thanks for the lightning quick review and integration @theacodes ! ⚡️

@dhermes

This comment has been minimized.

Copy link

commented Jul 21, 2018

https://packaging.python.org/guides/packaging-binary-extensions/ still says "Last Reviewed: 2013-12-08". Need to update?

@theacodes

This comment has been minimized.

Copy link
Member

commented Jul 24, 2018

@dhermes probably. We've been removing those things from pages, so it'd be nice if someone sent a PR to do that to this page.

@dhermes

This comment has been minimized.

Copy link

commented Jul 24, 2018

I feel the nudge to send the PR 😀 but I like those :Page Status:, :Last Reviewed: extras so it'd be sad if I gave them the ax. (Though I understand why they'd get stale.)

@ncoghlan

This comment has been minimized.

Copy link
Member

commented Jul 28, 2018

Something along the lines of the discussion at https://groups.google.com/forum/#!topic/sphinx-dev/6G8TWtIVN14 to show when a particular page was last touched might be interesting.

Either way, we rarely remember to update the "last reviewed" markers, so I don't think they're accurate enough to be useful - they're currently more likely to give the impression that info is more outdated than it actually is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.