Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce emphasis on virtualenv #606

Merged
merged 1 commit into from Apr 23, 2019

Conversation

@cs01
Copy link
Contributor

cs01 commented Apr 20, 2019

  • Replace use of virtualenv with virtual environment when referring to a virtual environment
    • Only use the term virtualenv when referring to the tool.
  • Recommend venv over virtualenv. Make it clear that venv is preferred for Python 3.
@ncoghlan

This comment has been minimized.

Copy link
Member

ncoghlan commented Apr 21, 2019

@theacodes This looks good to me, but the file name change has the potential to break incoming links.

Do you still have something set up in nox to detect & add the redirects to deal with that? (I remember we had to turn it off in CI because it had trouble coping with new sections being added to existing pages)

@theacodes

This comment has been minimized.

Copy link
Member

theacodes commented Apr 21, 2019

Yes, this will definitely break links.

I can either add redirects after this is merged or we can keep the old file name. I have no preference.

I turned off the link checker when we stopped having so much churn.

@ncoghlan

This comment has been minimized.

Copy link
Member

ncoghlan commented Apr 23, 2019

I think the canonical URL change makes sense, so if you're happy to add the redirects, let's go ahead!

@ncoghlan ncoghlan closed this Apr 23, 2019
@ncoghlan ncoghlan reopened this Apr 23, 2019
@ncoghlan

This comment has been minimized.

Copy link
Member

ncoghlan commented Apr 23, 2019

It helps if I push the right button...

@ncoghlan ncoghlan merged commit 84c5747 into pypa:master Apr 23, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@theacodes

This comment has been minimized.

Copy link
Member

theacodes commented Apr 23, 2019

Cool, docs have been built and the redirect is in place. Thanks, everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.