Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use python3 -m when installing pipx #631

Merged

Conversation

@cs01
Copy link
Contributor

cs01 commented Aug 1, 2019

As noted in #607, pipx may not be on the user's PATH when installed with the --user flag. This PR adds the python3 -m prefix when ensuring the PATH has paths pipx expects. Note that pipx now considers ensurepath best practice again (it's no longer deprecated).

@cs01

This comment has been minimized.

Copy link
Contributor Author

cs01 commented Aug 3, 2019

@pfmoore
pfmoore approved these changes Aug 3, 2019
Copy link
Member

pfmoore left a comment

On Windows, it would be py -3 -m pipx, but I don't think it's worth complicating the docs by getting into those nuances.

@pradyunsg

This comment has been minimized.

Copy link
Member

pradyunsg commented Aug 4, 2019

/cc @di since I'm pretty sure he's in charge now. :)

@ncoghlan ncoghlan merged commit ecf061c into pypa:master Aug 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ncoghlan

This comment has been minimized.

Copy link
Member

ncoghlan commented Aug 14, 2019

Yeah, there's an existing issue for python3 being problematic: #453

@cs01 cs01 deleted the cs01:cs01/update-pipx-installation-instructions branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.