Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sys.implementation.name if available #193

Closed
pradyunsg opened this issue Sep 1, 2019 · 0 comments · Fixed by #218
Closed

Use sys.implementation.name if available #193

pradyunsg opened this issue Sep 1, 2019 · 0 comments · Fixed by #218

Comments

@pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Sep 1, 2019

From https://www.python.org/dev/peps/pep-0425/#python-tag

Other Python implementations should use sys.implementation.name.


We should probably use sys.implementation.name in packaging.tags, instead of platform.python_implementation().lower(), if it exists.

name = platform.python_implementation().lower()


Relevant discussion about platform.python_implementation() vs sys.implementation: https://www.python.org/dev/peps/pep-0421/#platform-python-implementation

@brettcannon brettcannon changed the title [tags] Use sys.implementation.name if available Use sys.implementation.name if available Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.