Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce packaging.tags #156

Merged
merged 50 commits into from May 10, 2019

Conversation

@brettcannon
Copy link
Contributor

commented Dec 15, 2018

Add support for PEP 425: Compatibility Tags for Built Distributions.

Closes #83

@njsmith
Copy link
Member

left a comment

Awesome to see this moving forward :-). A few comments below.

Are you planning to switch pip over to using this?

packaging/tags.py Outdated Show resolved Hide resolved
packaging/tags.py Show resolved Hide resolved
docs/tags.rst Outdated Show resolved Hide resolved

@dstufft dstufft assigned dstufft and unassigned dstufft Dec 16, 2018

@dstufft dstufft self-requested a review Dec 16, 2018

@dstufft

This comment has been minimized.

Copy link
Member

commented Dec 16, 2018

Just to set expectations, I'm probably not going to get to looking at this until Christmas-ish. It's significant new functionality and it'll take me a bit to ramp up on it.

@brettcannon

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2018

@dstufft Thanks for the update and no problem from my end. Have a happy holidays!

@brettcannon

This comment has been minimized.

Copy link
Contributor Author

commented Jan 4, 2019

OK, the PR now passes CI! Over to you, @dstufft 😁

@brettcannon

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

Anything I can do to help move this forward, @dstufft ? Do you want me to break this up somewhat? I could do platform-independent stuff and then do separate PRs for Windows, Linux, and macOS if that would help get this reviewed.

@dstufft

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

No, I just forgot about it. I'll take a look at it later this week. Thanks for the reminder!

@brettcannon

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2019

I now have a use for this at work, so I'm prodding again about what I can do to help get this reviewed.

@dstufft
Copy link
Member

left a comment

Made some comments. I feel really bad about how long I left this sit, so feel free to push back on things if reworking them would require a bunch of additional effort. Overall I think the structure here is fairly reasonable.

packaging/tags.py Outdated Show resolved Hide resolved
packaging/tags.py Show resolved Hide resolved
packaging/tags.py Outdated Show resolved Hide resolved
packaging/tags.py Show resolved Hide resolved
packaging/tags.py Outdated Show resolved Hide resolved
packaging/tags.py Show resolved Hide resolved
packaging/tags.py Outdated Show resolved Hide resolved
packaging/tags.py Outdated Show resolved Hide resolved
packaging/tags.py Show resolved Hide resolved
@brettcannon

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

@dstufft PTAL

@dstufft
Copy link
Member

left a comment

Awesome. This looks great Sorry that it took so long to get reviewed.

@dstufft dstufft merged commit 76bc450 into pypa:master May 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@brettcannon brettcannon deleted the brettcannon:tags branch May 10, 2019

@brettcannon

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

Thanks for landing this! And no problem about the time, just glad it worked out in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.