Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on attrs #179

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@dcermak
Copy link
Contributor

commented Aug 13, 2019

  • replace tags.Tag with a custom implementation instead of using @attr.s
  • add a sanity check for __hash__()
  • drop attrs from setup.py

This fixes #178

- replace tags.Tag with a custom implementation instead of using @attr.s
- add a sanity check for __hash__()
- drop attrs from setup.py

This fixes #178
@pradyunsg pradyunsg requested a review from brettcannon Aug 13, 2019
Copy link
Member

left a comment

I'm cool with this.

Copy link
Contributor

left a comment

If we are going to drop attr then I would argue to keep the replacement as simple as possible while still providing the expected functionality.

packaging/tags.py Show resolved Hide resolved
packaging/tags.py Show resolved Hide resolved
@brettcannon brettcannon merged commit 9bc2596 into pypa:master Aug 15, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brettcannon

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

Thanks, @dcermak for the PR and the patience while I realized why I was wrong. 😉

def __init__(self, interpreter, abi, platform):
self._interpreter = str.lower(interpreter)
self._abi = str.lower(abi)
self._platform = str.lower(platform)

This comment has been minimized.

Copy link
@asottile

asottile Aug 18, 2019

Contributor

should these be interpreter.lower() / abi.lower() / etc.

This comment has been minimized.

Copy link
@brettcannon

brettcannon Aug 19, 2019

Contributor

@asottile it wouldn't hurt, but it technically isn't wrong. :) I'll quickly fix it separately.

@dcermak dcermak deleted the dcermak:drop_attrs branch Aug 19, 2019
@benoit-pierre

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

I would be great if there was a new release with this change.

@pradyunsg

This comment has been minimized.

Copy link
Member

commented Aug 25, 2019

I would be great if there was a new release with this change.

Yep -- @brettcannon do you reckon you can find time to cut a release in the coming week? I don't know when I'd be able to make time TBH.

@pradyunsg

This comment has been minimized.

Copy link
Member

commented Aug 25, 2019

I would be great

Related: you're pretty great already @benoit-pierre, if you ask me. :)

@brettcannon

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

@pradyunsg I'll see if I can find the time, but it might not be until the latter half of September (although I might squeeze some time in during the Python core dev sprint before then).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.