Drop dependency on attrs #179
Conversation
- replace tags.Tag with a custom implementation instead of using @attr.s - add a sanity check for __hash__() - drop attrs from setup.py This fixes pypa#178
|
Thanks, @dcermak for the PR and the patience while I realized why I was wrong. |
| def __init__(self, interpreter, abi, platform): | ||
| self._interpreter = str.lower(interpreter) | ||
| self._abi = str.lower(abi) | ||
| self._platform = str.lower(platform) |
There was a problem hiding this comment.
should these be interpreter.lower() / abi.lower() / etc.
There was a problem hiding this comment.
@asottile it wouldn't hurt, but it technically isn't wrong. :) I'll quickly fix it separately.
|
I would be great if there was a new release with this change. |
Yep -- @brettcannon do you reckon you can find time to cut a release in the coming week? I don't know when I'd be able to make time TBH. |
Related: you're pretty great already @benoit-pierre, if you ask me. :) |
|
@pradyunsg I'll see if I can find the time, but it might not be until the latter half of September (although I might squeeze some time in during the Python core dev sprint before then). |
tags.Tagwith a custom implementation instead of using@attr.s__hash__()setup.pyThis fixes #178