New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle <base> in line with HTML spec #1101

Closed
gsnedders opened this Issue Aug 1, 2013 · 0 comments

Comments

Projects
None yet
2 participants
@gsnedders
Contributor

gsnedders commented Aug 1, 2013

Per spec, the first base element with a href attribute provides the document base URL.

Therefore, the following currently gives the wrong result: <base><base href="http://example.com/">. Currently pip finds the first one and then concludes there's no URL so falls back to the document URL; it should find the second and ues that.

@dstufft dstufft added this to the 1.6 milestone Mar 28, 2014

dstufft added a commit to dstufft/pip that referenced this issue Jun 13, 2014

@dstufft dstufft closed this in e05a759 Jun 13, 2014

dstufft added a commit that referenced this issue Jun 13, 2014

Merge pull request #1869 from dstufft/properly-handle-base
Fix #1101 - Properly handle a <base> without a href
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment