New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ZIP64 when downloading #1319

Closed
typeshige opened this Issue Nov 15, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@typeshige

typeshige commented Nov 15, 2013

When doing a pip install --download, I ran into a problem when trying to zip a huge package.

Is there any harm in allowing ZIP64?

In req.py line 562 adding allowZip64=True

zip = zipfile.ZipFile(archive_path, 'w', zipfile.ZIP_DEFLATED, allowZip64=True)

Is there any harm in making this change? I think it won't affect how it zips when below the limit of standard zip.

@dholth

This comment has been minimized.

Show comment
Hide comment
@dholth

dholth Dec 13, 2013

Member

LGTM

Member

dholth commented Dec 13, 2013

LGTM

@typeshige

This comment has been minimized.

Show comment
Hide comment
@typeshige

typeshige Jan 24, 2014

Any thoughts on this? Any downsides?

typeshige commented Jan 24, 2014

Any thoughts on this? Any downsides?

@dstufft

This comment has been minimized.

Show comment
Hide comment
@dstufft

dstufft Jan 24, 2014

Member

I can't think of any! Can you send a PR?

Member

dstufft commented Jan 24, 2014

I can't think of any! Can you send a PR?

@dstufft dstufft closed this in 169379d Jun 13, 2014

dstufft added a commit that referenced this issue Jun 13, 2014

Merge pull request #1868 from dstufft/allow-zip64
Fix #1319 - Allow use of Zip64 extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment