Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
pip wheel return code 0 on failure. #1769
Upon running "pip wheel", if the wheel is not build successfully, then the error code should be non-zero. On version 1.5.4, I get this as I have a dependency on bin/fubar that does not exist.
Is this a bug or am I missing something?
The fix, if there is a need for a fix, is trivially easy: Just add return values in WheelBuilder.build() so it returns 0 if build_success and 101 (say) if build_failure as well as adding a return command/wheel.py line 189.
I've tested this by hacking the source on my machine and it works for me. However, I have not clone and ran all the unit tests etc... Is the above enough or do you wish a pull request?