New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip wheel return code 0 on failure. #1769

Closed
kierun opened this Issue Apr 28, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@kierun

kierun commented Apr 28, 2014

Upon running "pip wheel", if the wheel is not build successfully, then the error code should be non-zero. On version 1.5.4, I get this as I have a dependency on bin/fubar that does not exist.

[...]
error: can't copy 'bin/fubar': doesn't exist or not a regular file
----------------------------------------
  Failed building wheel for test
Failed to build test
Cleaning up...
  Removing temporary dir /home/***/repos/pip-core/virt/env/build/build...
build(feature/master|✚2); echo $?
0

Is this a bug or am I missing something?

@kierun

This comment has been minimized.

Show comment
Hide comment
@kierun

kierun Apr 28, 2014

The fix, if there is a need for a fix, is trivially easy: Just add return values in WheelBuilder.build() so it returns 0 if build_success and 101 (say) if build_failure as well as adding a return command/wheel.py line 189.

I've tested this by hacking the source on my machine and it works for me. However, I have not clone and ran all the unit tests etc... Is the above enough or do you wish a pull request?

kierun commented Apr 28, 2014

The fix, if there is a need for a fix, is trivially easy: Just add return values in WheelBuilder.build() so it returns 0 if build_success and 101 (say) if build_failure as well as adding a return command/wheel.py line 189.

I've tested this by hacking the source on my machine and it works for me. However, I have not clone and ran all the unit tests etc... Is the above enough or do you wish a pull request?

@pfmoore

This comment has been minimized.

Show comment
Hide comment
@pfmoore

pfmoore Apr 28, 2014

Member

That's fine, thanks for the report. I've created PR #1770 for this.

Member

pfmoore commented Apr 28, 2014

That's fine, thanks for the report. I've created PR #1770 for this.

@pfmoore

This comment has been minimized.

Show comment
Hide comment
@pfmoore

pfmoore Apr 29, 2014

Member

Closed via #1770

Member

pfmoore commented Apr 29, 2014

Closed via #1770

@pfmoore pfmoore closed this Apr 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment