Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal wheel cache #2140

Closed
qwcode opened this issue Nov 25, 2014 · 4 comments

Comments

Projects
None yet
5 participants
@qwcode
Copy link
Contributor

commented Nov 25, 2014

although we have pip wheel for generating wheels, and you can point at them with --find-links (see https://pip.pypa.io/en/latest/user_guide.html#installing-from-wheels), ideally we'd like wheels to be generated (when starting from sdist) and cached automatically for subsequent installs, without the user having to think about how to get the benefit of faster wheel installs.

the code would benefit as well from a clean separation of the build step (sdist -> wheel), from the install step (wheel -> dist-info).

see #1572 for a partial attempt that stalled, and conversation that followed.
(specifically, this comment from dstufft: #1572 (comment))

most likely the first release of this feature would have to be opt-in, considering that some packages don't build to wheel properly

@pfmoore

This comment has been minimized.

Copy link
Member

commented Nov 25, 2014

It's also worth noting that there are some small, mostly irrelevant, differences between installing from sdist and installing from wheel at the moment (most notably, Windows .exe wrappers are generated by different processes, and have subtly different behaviours). If we always built a wheel and installed from that, it would unify the behaviour, resulting in a slightly more consistent end user experience.

@bukzor

This comment has been minimized.

Copy link
Contributor

commented Dec 5, 2014

👍 👍

@remcohaszing

This comment has been minimized.

Copy link

commented Feb 13, 2015

I currently do this manually. It would be great to automate this by setting an option in pip.conf.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 1, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 1, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 1, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 1, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 1, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 1, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 1, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 2, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 2, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 2, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 2, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 2, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 3, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 6, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 6, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 7, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

dstufft added a commit to dstufft/pip that referenced this issue Apr 7, 2015

Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

dstufft added a commit to dstufft/pip that referenced this issue Apr 7, 2015

Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

dstufft added a commit to dstufft/pip that referenced this issue Apr 7, 2015

Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

dstufft added a commit to dstufft/pip that referenced this issue Apr 7, 2015

Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

dstufft added a commit to dstufft/pip that referenced this issue Apr 7, 2015

Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 7, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 8, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 8, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 9, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 9, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 9, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 9, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 9, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 9, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 9, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 10, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 10, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 10, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 12, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 13, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 13, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

rbtcollins pushed a commit to rbtcollins/pip that referenced this issue Apr 13, 2015

Robert Collins
Issue pypa#2140: Build wheels automatically
Building wheels before installing elminates a cause of broken environments -
where install fails after we've already installed one or more packages.

If a package fails to wheel, we run setup.py install as normally.

dstufft added a commit that referenced this issue Apr 13, 2015

Merge pull request #2618 from rbtcollins/issue-2140
Issue #2140: Build wheels during pip install
@dstufft

This comment has been minimized.

Copy link
Member

commented Apr 13, 2015

Going to close this since we now cache wheels by default.

@dstufft dstufft closed this Apr 13, 2015

@lock lock bot added the S: auto-locked label Jun 5, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.