New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in RequirementSet.copy_to_build_dir #266

Closed
bradleyayers opened this Issue Apr 24, 2011 · 1 comment

Comments

Projects
None yet
2 participants
@bradleyayers
Contributor

bradleyayers commented Apr 24, 2011

The call_subprocess call in pip.req.RequestSet.copy_to_build_dir doesn't set the current working directory for the setup.py clean process. This makes pip bundle ... break on any package that implements clean functionality and makes assumptions about the current working directory (e.g. matplotlib, numpy).

For example in numpy, setup.py contains the following code:

if os.path.exists('numpy/version.py'):
    os.remove('numpy/version.py')

The solution is to add cwd=dest as a keyword argument: https://gist.github.com/939416

bradleyayers added a commit to bradleyayers/pip that referenced this issue Apr 24, 2011

jezdez added a commit that referenced this issue Apr 25, 2011

Merged pull request #267 from bradleyayers/develop.
Fixed bug #266 and corrected some minor coding style problems nearby.
@pnasrat

This comment has been minimized.

Show comment
Hide comment
@pnasrat

pnasrat May 3, 2011

Contributor

Fixed by merge - thanks for the patch @bradleyayers

Contributor

pnasrat commented May 3, 2011

Fixed by merge - thanks for the patch @bradleyayers

@pnasrat pnasrat closed this May 3, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment