New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install <url> does not use the Content-Disposition header as a filename fallback. #273

Closed
bradleyayers opened this Issue Apr 28, 2011 · 3 comments

Comments

Projects
None yet
2 participants
@bradleyayers
Contributor

bradleyayers commented Apr 28, 2011

If I have a package available at http://server.com/package/ that returns a HTTP response with a Content-Disposition header, pip thinks the filename is package.obj rather than the filename provided in the Content-Disposition header.

@pnasrat

This comment has been minimized.

Show comment
Hide comment
@pnasrat

pnasrat Apr 28, 2011

Contributor

Can you give a sample of say curl -I http://server.com/package/

For reference http://www.ietf.org/rfc/rfc2183.txt

Contributor

pnasrat commented Apr 28, 2011

Can you give a sample of say curl -I http://server.com/package/

For reference http://www.ietf.org/rfc/rfc2183.txt

bradleyayers added a commit to bradleyayers/pip that referenced this issue Apr 28, 2011

* Used a more pythonic approach to buffered file reading
* Alphabetised standard library imports
* Made some minor PEP8 compliance changes
* Fixed issue pypa#273
@bradleyayers

This comment has been minimized.

Show comment
Hide comment
@bradleyayers

bradleyayers Apr 28, 2011

Contributor

Gah it looks like a spammed up this thread a bit with commits. I came here to say I've written a patch and done a pull request that fixes this issue.

Contributor

bradleyayers commented Apr 28, 2011

Gah it looks like a spammed up this thread a bit with commits. I came here to say I've written a patch and done a pull request that fixes this issue.

carljm added a commit that referenced this issue Apr 28, 2011

bradleyayers pushed a commit to bradleyayers/pip that referenced this issue Apr 29, 2011

carljm added a commit that referenced this issue Apr 29, 2011

@pnasrat

This comment has been minimized.

Show comment
Hide comment
@pnasrat

pnasrat May 1, 2011

Contributor

This has been merged, I believe this can be closed.

Contributor

pnasrat commented May 1, 2011

This has been merged, I believe this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment