New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle wheels that are only OS specific #3202

Closed
dstufft opened this Issue Oct 22, 2015 · 9 comments

Comments

Projects
None yet
6 participants
@dstufft
Member

dstufft commented Oct 22, 2015

Some wheels are not specific to a particular Python version but are specific to a particular OS. An example would be something like airship_steamcloud-1.4.8-py2.py3-none-macosx_10_6_universal.whl. This should work, but it doesn't currently because we don't generate all of the needed tags to make it work.

@carlosliam

This comment has been minimized.

Show comment
Hide comment
@carlosliam

carlosliam Jan 13, 2016

Contributor

Any progress on this? If not, where in the code are the tags generated, so that I could take a look at it?

Contributor

carlosliam commented Jan 13, 2016

Any progress on this? If not, where in the code are the tags generated, so that I could take a look at it?

@dholth

This comment has been minimized.

Show comment
Hide comment
@dholth
Member

dholth commented Jan 13, 2016

@carlosliam

This comment has been minimized.

Show comment
Hide comment
@carlosliam

carlosliam Jan 13, 2016

Contributor

Doesn't seem like it...

carloss-mbp:airship aarzee$ pip install --use-wheel --no-index --find-links=dist airship-icloud
Ignoring indexes: https://pypi.python.org/simple
Collecting airship-icloud
  Could not find a version that satisfies the requirement airship-icloud (from versions: )
No matching distribution found for airship-icloud
carloss-mbp:airship aarzee$ file dist/airship_icloud-1.5.1-py2.py3-none-macosx_10_7_universal.whl 
dist/airship_icloud-1.5.1-py2.py3-none-macosx_10_7_universal.whl: Zip archive data, at least v2.0 to extract
Contributor

carlosliam commented Jan 13, 2016

Doesn't seem like it...

carloss-mbp:airship aarzee$ pip install --use-wheel --no-index --find-links=dist airship-icloud
Ignoring indexes: https://pypi.python.org/simple
Collecting airship-icloud
  Could not find a version that satisfies the requirement airship-icloud (from versions: )
No matching distribution found for airship-icloud
carloss-mbp:airship aarzee$ file dist/airship_icloud-1.5.1-py2.py3-none-macosx_10_7_universal.whl 
dist/airship_icloud-1.5.1-py2.py3-none-macosx_10_7_universal.whl: Zip archive data, at least v2.0 to extract
@dholth

This comment has been minimized.

Show comment
Hide comment
@dholth

dholth Jan 13, 2016

Member

It might be necessary to scroll up a few lines to the MacOSX-specific portion of pep425tags.py and add the pyX-none-arch there. OSX has a lot of compatible architecture tags.

Member

dholth commented Jan 13, 2016

It might be necessary to scroll up a few lines to the MacOSX-specific portion of pep425tags.py and add the pyX-none-arch there. OSX has a lot of compatible architecture tags.

@carlosliam

This comment has been minimized.

Show comment
Hide comment
@carlosliam

carlosliam Jan 13, 2016

Contributor

Would it be alright to, instead of the current system which involves a lot of unneeded code, use itertools.product() to accomplish the goal of generating all the possible tags? This way, we only need to generate the different possible values for the Python, ABI and platform tags separately, instead of generating whole tags at once.

Contributor

carlosliam commented Jan 13, 2016

Would it be alright to, instead of the current system which involves a lot of unneeded code, use itertools.product() to accomplish the goal of generating all the possible tags? This way, we only need to generate the different possible values for the Python, ABI and platform tags separately, instead of generating whole tags at once.

@pfmoore

This comment has been minimized.

Show comment
Hide comment
@pfmoore

pfmoore Jan 13, 2016

Member

IIRC, you need to generate them in priority order, so that the "best match" is first in the list. This is necessary for when multiple wheels match, to know which one to choose.

Member

pfmoore commented Jan 13, 2016

IIRC, you need to generate them in priority order, so that the "best match" is first in the list. This is necessary for when multiple wheels match, to know which one to choose.

@carlosliam

This comment has been minimized.

Show comment
Hide comment
@carlosliam

carlosliam Jan 27, 2016

Contributor

Are there any changes to be made to the PR?

Contributor

carlosliam commented Jan 27, 2016

Are there any changes to be made to the PR?

@ogrisel

This comment has been minimized.

Show comment
Hide comment
@ogrisel

ogrisel Feb 23, 2016

Contributor

@Aarzee this is possibly fixed by #3497 (diff)

Contributor

ogrisel commented Feb 23, 2016

@Aarzee this is possibly fixed by #3497 (diff)

@dstufft

This comment has been minimized.

Show comment
Hide comment
@dstufft

dstufft Mar 4, 2016

Member

It appears that this is now working in the develop branch.

Member

dstufft commented Mar 4, 2016

It appears that this is now working in the develop branch.

@dstufft dstufft closed this Mar 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment