Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Do not use $PWD in installation proccess #381
Please see this gist:
When I don't use the
So, the problem is:
added a commit
Nov 25, 2011
+1 pip shouldnt ever expect to use pwd/cwd for building or storing any files. It might write in directories which possibly breaks things
failed installs leave data within the directory including
also I do not agree with the proposed fix for only checking if cwd is writable. pip working dir should either be
I decided to tackle this bug, since as commented above, the proposed patch still attempts to write to pwd/cwd if it is writeable.
However, in doing so, there's another issue I discovered- before, locations.py would not actually create the build folder, only define the name. The actual folder would be created later in the process, and that is when it would be marked for deletion. If the folder already exists (which it will, now that locations.py / tempfile is creating it previously), it will not be marked for delete.
This would apply to the already posted patch as well- you would get a lot of temporary folders floating around in /tmp that will never be automatically deleted.