New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate --default-vcs option #4052

Closed
xavfernandez opened this Issue Nov 1, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@xavfernandez
Contributor

xavfernandez commented Nov 1, 2016

It clotters the code from one function call to the other to end up only being used here:

pip/pip/req/req_install.py

Lines 1159 to 1160 in dd7df7f

if default_vcs:
url = default_vcs + '+' + url

It does not seem that useful and is an hidden option dating from f5da534, for backward compatibility with poacheggs...

cc @pypa/pip-committers

xavfernandez added a commit to xavfernandez/pip that referenced this issue Nov 1, 2016

@xavfernandez xavfernandez added this to the 9.0 milestone Nov 1, 2016

@xavfernandez

This comment has been minimized.

Show comment
Hide comment
@xavfernandez

xavfernandez Nov 1, 2016

Contributor

@dstufft I'd like to include it in 9.0. Feel free to remove it if you disagree :)

Contributor

xavfernandez commented Nov 1, 2016

@dstufft I'd like to include it in 9.0. Feel free to remove it if you disagree :)

dstufft added a commit that referenced this issue Nov 2, 2016

@dstufft dstufft closed this Nov 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment