New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More problems with upgrading with 'git+ssh' #487

Closed
aknapp opened this Issue Mar 16, 2012 · 6 comments

Comments

Projects
None yet
2 participants
@aknapp

aknapp commented Mar 16, 2012

(putting this in a new issue in case you didn't see my comment in the closed issue #486)

So, I just tried the fix for #486 out, and it looks like it's still a little wonky. It doesn't fail out now, but for packages that we have a local git repo for (say, django, django-hosts, protobuf, etc..), it installs correctly the first time from our repos (on a bare virtualenv), but when I upgrade, it goes and fetches a version from pypi instead of from our git repo.

I just seems like the order is off. Any ideas?

Example:

We have a local copy of protobuf in a git repo. When I first install it from a requirements file, it works fine:

Downloading/unpacking protobuf from git+ssh://gitosis@internal.git.server/thirdparty/protobuf-python.git@a8c173e08fe262cbdb64989d11bbde32535598ea (from -r /home/andrew/dev/git/requirements.txt (line 2))
  Cloning ssh://gitosis@internal.git.server/thirdparty/protobuf-python.git (to a8c173e08fe262cbdb64989d11bbde32535598ea) to /home/andrew/.env/env/build/protobuf
  Could not find a tag or branch 'a8c173e08fe262cbdb64989d11bbde32535598ea', assuming commit.
  Running setup.py egg_info for package protobuf

Now, when I upgrade the environment, it does this:

Downloading/unpacking protobuf from http://d.pypi.python.org/packages/source/p/protobuf/protobuf-2.4.1.tar.gz#md5=72f5141d20ab1bcae6b1e00acfb1068a (from -r /home/andrew/dev/git/requirements.txt (line 2))
  Using download cache from /home/andrew/.pip-cache/http%3A%2F%2Fd.pypi.python.org%2Fpackages%2Fsource%2Fp%2Fprotobuf%2Fprotobuf-2.4.1.tar.gz
  Running setup.py egg_info for package protobuf

It goes out to pypi and downloads a newer version and installs it (our git repo version is 2.4.0a, and on upgrade it installs 2.4.1). Hope this helps.

@carljm

This comment has been minimized.

Show comment
Hide comment
@carljm

carljm Mar 16, 2012

Contributor

Yup, thanks for the additional report - I see the problem and I think I have a fix - traveling today but I'll get it in soon. This is a pretty serious regression so once we've verified it's fixed I'd like to do a point release.

Contributor

carljm commented Mar 16, 2012

Yup, thanks for the additional report - I see the problem and I think I have a fix - traveling today but I'll get it in soon. This is a pretty serious regression so once we've verified it's fixed I'd like to do a point release.

@aknapp

This comment has been minimized.

Show comment
Hide comment
@aknapp

aknapp Mar 17, 2012

Awesome, thanks for the quick response!

Let me know if I can do anything else to help.

aknapp commented Mar 17, 2012

Awesome, thanks for the quick response!

Let me know if I can do anything else to help.

@carljm carljm closed this in 19e1eab Mar 20, 2012

@carljm

This comment has been minimized.

Show comment
Hide comment
@carljm

carljm Mar 20, 2012

Contributor

K, should be fixed; let me know if you're still seeing issues.

Contributor

carljm commented Mar 20, 2012

K, should be fixed; let me know if you're still seeing issues.

@aknapp

This comment has been minimized.

Show comment
Hide comment
@aknapp

aknapp Mar 20, 2012

That worked for me, thanks!

Are you planning to roll a new version sometime soon?

aknapp commented Mar 20, 2012

That worked for me, thanks!

Are you planning to roll a new version sometime soon?

@carljm

This comment has been minimized.

Show comment
Hide comment
@carljm

carljm Mar 20, 2012

Contributor

I'd like to, there's one other high-priority fix I'd like to get in first.

Contributor

carljm commented Mar 20, 2012

I'd like to, there's one other high-priority fix I'd like to get in first.

@aknapp

This comment has been minimized.

Show comment
Hide comment
@aknapp

aknapp Mar 20, 2012

Cool, we'll just roll with our own package for the time being then.

Thanks a ton :)

aknapp commented Mar 20, 2012

Cool, we'll just roll with our own package for the time being then.

Thanks a ton :)

bernardofire added a commit to bernardofire/pip that referenced this issue May 2, 2012

ptone added a commit to ptone/pip that referenced this issue Jun 21, 2012

Merge branches 'develop' and 'develop' of git://github.com/pypa/pip i…
…nto develop

* 'develop' of git://github.com/pypa/pip:
  Fixed a test that was failing intermittently due to pyc file race conditions.
  Fixed pypa#487 - don't check for best-version-already-installed with explicit-URL requirements when upgrading.
  Issue pypa#482 search raises exception.
  Fix upgrade of VCS requirement with otherwise nonexistent egg. Fixes pypa#486.

* 'develop' of git://github.com/pypa/pip:
  Fixed a test that was failing intermittently due to pyc file race conditions.
  Fixed pypa#487 - don't check for best-version-already-installed with explicit-URL requirements when upgrading.
  Issue pypa#482 search raises exception.
  Fix upgrade of VCS requirement with otherwise nonexistent egg. Fixes pypa#486.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment