Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip 9 offers upgrades to prereleases #5175

Closed
mgedmin opened this issue Apr 5, 2018 · 2 comments

Comments

3 participants
@mgedmin
Copy link

commented Apr 5, 2018

  • Pip version: 9.0.3
  • Python version: 2.7.14
  • Operating system: Ubuntu 17.10

Description:

Any pip command says

You are using pip version 9.0.3, however version 10.0.0b2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

I'm not sure it's a good idea to offer upgrades to pre-release versions? Anyway, the suggested command doesn't work (because it needs --pre to allow upgrades to pre-release versions):

Requirement already up-to-date: pip in /home/mg/.venv/lib/python2.7/site-packages
You are using pip version 9.0.3, however version 10.0.0b2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
@pfmoore

This comment has been minimized.

Copy link
Member

commented Apr 5, 2018

Thanks for reporting this! It's only likely to be an issue for a relatively short period (pip 10 final is due in just over a week) but it's good to have the problem recorded so that we can ensure it doesn't crop up for future betas.

@pradyunsg

This comment has been minimized.

Copy link
Member

commented Apr 7, 2018

pypi_version = str(

Relevant line is this. We'd want to filter out pre-releases here.,

uranusjr added a commit to uranusjr/pip that referenced this issue Oct 30, 2018

Isolate best candidate logic in PackageFinder
The isolated logic is then used to find the latest pip in the self version
check. This avoids the self version check to duplicate this candidate
discovery logic (and implement it incorrectly).

Fix pypa#5175, close pypa#5928.

uranusjr added a commit to uranusjr/pip that referenced this issue Oct 30, 2018

Isolate, reuse PackageFinder best candidate logic
Split out how PackageFinder finds the best candidate, and reuse it in the
self version check, to avoid the latter duplicating (and incorrectly
implementing) the same logic.

Fix pypa#5175, close pypa#5928.

uranusjr added a commit to uranusjr/pip that referenced this issue Oct 30, 2018

Isolate, reuse PackageFinder best candidate logic
Split out how PackageFinder finds the best candidate, and reuse it in the
self version check, to avoid the latter duplicating (and incorrectly
implementing) the same logic.

Fix pypa#5175, close pypa#5928.

uranusjr added a commit to uranusjr/pip that referenced this issue Oct 30, 2018

Isolate, reuse PackageFinder best candidate logic
Split out how PackageFinder finds the best candidate, and reuse it in the
self version check, to avoid the latter duplicating (and incorrectly
implementing) the same logic.

Fix pypa#5175, close pypa#5928.

PyPA Sprint Weekend at Bloomberg (2018) automation moved this from In progress to Closed Issues Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.