Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyring support #5948

Closed
zooba opened this issue Oct 27, 2018 · 1 comment

Comments

@zooba
Copy link
Contributor

commented Oct 27, 2018

What's the problem this feature will solve?
Use keyring to resolve (username and) passwords for a repository.

Describe the solution you'd like
In download.py when a 401 is being handled,

This would enable the use of additional backends to store and resolve passwords for installing from private feeds.

Alternative Solutions
For the current (private) previews of this in some services, we generate a new password and provide it to users to include in a pip.ini file. This change would allow them to simply provide the URL on the command line and install a separate package to generate credentials on the fly.

Additional context
See jaraco/keyring#350 for an addition to keyring that will be used (when available) to also resolve usernames as well as passwords.

@zooba

This comment has been minimized.

Copy link
Contributor Author

commented Oct 27, 2018

I plan to work on this at the PyPA sprint.

zooba added a commit to zooba/pip that referenced this issue Oct 27, 2018

zooba added a commit to zooba/pip that referenced this issue Oct 30, 2018

zooba added a commit to zooba/pip that referenced this issue Nov 6, 2018

zooba added a commit to zooba/pip that referenced this issue Feb 6, 2019

zooba added a commit to zooba/pip that referenced this issue Feb 12, 2019

Issue pypa#5948: Enable keyring support
This requires keyring and any backends to be installed separately.
Once discovered, it will be used to retrieve credentials by index URL
and netloc before prompting. If the user is prompted and the
credentials work, they will (optionally) be saved to keyring against
the netloc of the requested URL.

zooba added a commit to zooba/pip that referenced this issue May 7, 2019

Issue pypa#5948: Enable keyring support
This requires keyring and any backends to be installed separately.
Once discovered, it will be used to retrieve credentials by index URL
and netloc before prompting. If the user is prompted and the
credentials work, they will (optionally) be saved to keyring against
the netloc of the requested URL.

PyPA Sprint Weekend at Bloomberg (2018) automation moved this from In progress to Closed Issues May 10, 2019

dstufft added a commit that referenced this issue May 10, 2019

Merge pull request #5952 from zooba/issue-5948
Fixes #5948 Adds keyring support

@lock lock bot added the S: auto-locked label Jun 9, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jun 9, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
2 participants
You can’t perform that action at this time.